From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com,
jbrunet@baylibre.com, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
Vyacheslav Bocharov <adeep@lexina.in>
Subject: Re: [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node
Date: Fri, 13 Jan 2023 08:58:44 +0100 [thread overview]
Message-ID: <c8057da5-fa0f-4801-a3b9-12b9215bc29a@linaro.org> (raw)
In-Reply-To: <20230111211350.1461860-2-martin.blumenstingl@googlemail.com>
On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Unit addresses should be written using lower-case hex characters. Use
> wifi_mac@c to fix a yaml schema validation error once the eFuse
> dt-bindings have been converted to a yaml schema:
> efuse: Unevaluated properties are not allowed ('wifi_mac@C' was
> unexpected)
>
> Also node names should use hyphens instead of underscores as the latter
> can also cause warnings.
>
> Fixes: abfaae24ecf3 ("arm64: dts: meson-gxl: add support for JetHub H1")
> Acked-by: Vyacheslav Bocharov <adeep@lexina.in>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - Added Vyacheslav's Acked-by (originally given as "Vyachesav", but my
> understanding is that this was a typo
> - Also replace the underscore in the node name with a hyphen
>
> .../boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> index 6831137c5c10..270483e007bc 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts
> @@ -90,7 +90,7 @@ bt_mac: bt_mac@6 {
> reg = <0x6 0x6>;
> };
>
> - wifi_mac: wifi_mac@C {
> + wifi_mac: wifi-mac@c {
> reg = <0xc 0x6>;
> };
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-13 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
2023-01-13 7:58 ` neil.armstrong [this message]
2023-01-11 21:13 ` [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name Martin Blumenstingl
2023-01-13 7:58 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-13 7:59 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY " Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-13 8:03 ` [PATCH v2 0/6] arm64: dts: small .dts fixes Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8057da5-fa0f-4801-a3b9-12b9215bc29a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=adeep@lexina.in \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®