From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com,
jbrunet@baylibre.com, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address
Date: Fri, 13 Jan 2023 08:59:44 +0100 [thread overview]
Message-ID: <fbeb53ec-78cb-faf1-85ef-1c6f128c489e@linaro.org> (raw)
In-Reply-To: <20230111211350.1461860-7-martin.blumenstingl@googlemail.com>
On 11/01/2023 22:13, Martin Blumenstingl wrote:
> Node names should be generic and use hyphens instead of underscores to
> not cause warnings. Also nodes without a reg property should not have a
> unit-address. Change the scpi_dvfs node to use clock-controller as node
> name without a unit address (since it does not have a reg property).
>
> Fixes: 70db166a2baa ("ARM64: dts: meson-gxbb: Add SCPI with cpufreq & sensors Nodes")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> changes from v1 -> v2:
> - new patch
>
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index f8b115cd6775..a79a35e84281 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -250,7 +250,7 @@ scpi {
> scpi_clocks: clocks {
> compatible = "arm,scpi-clocks";
>
> - scpi_dvfs: scpi_clocks@0 {
> + scpi_dvfs: clock-controller {
> compatible = "arm,scpi-dvfs-clocks";
> #clock-cells = <1>;
> clock-indices = <0>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-13 8:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 21:13 [PATCH v2 0/6] arm64: dts: small .dts fixes Martin Blumenstingl
2023-01-11 21:13 ` [PATCH v2 1/6] arm64: dts: meson-gxl: jethub-j80: Fix WiFi MAC address node Martin Blumenstingl
2023-01-13 7:58 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 2/6] arm64: dts: meson-gxl: jethub-j80: Fix Bluetooth MAC node name Martin Blumenstingl
2023-01-13 7:58 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 3/6] arm64: dts: meson-axg: jethub-j1xx: Fix MAC address node names Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 4/6] arm64: dts: meson-gx: Fix Ethernet MAC address unit name Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-13 7:59 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 5/6] arm64: dts: meson-g12a: Fix internal Ethernet PHY " Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong
2023-01-11 21:13 ` [PATCH v2 6/6] arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address Martin Blumenstingl
2023-01-13 7:59 ` neil.armstrong [this message]
2023-01-13 8:03 ` [PATCH v2 0/6] arm64: dts: small .dts fixes Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbeb53ec-78cb-faf1-85ef-1c6f128c489e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®