mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH] pinctrl: meson-gxbb: remove non-existing pin GPIOX_22
@ 2017-06-07  5:44 Heiner Kallweit
  2017-06-07 11:27 ` Neil Armstrong
  2017-06-09  7:25 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2017-06-07  5:44 UTC (permalink / raw)
  To: linus-amlogic

After commit 34e61801a3b9 "pinctrl: meson-gxbb: Add missing GPIODV_18
pin entry" I started to get the following warning:

"meson-pinctrl c8834000.periphs:pinctrl at 4b0: names 119 do not match
number of GPIOs 120"

It turned out that not the mentioned commit has a problem, it just
revealed another problem which had existed before.

There is no PIN GPIOX_22 on Meson GXBB.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
index 8b716b93..a879cf07 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
@@ -138,7 +138,6 @@ static const struct pinctrl_pin_desc meson_gxbb_periphs_pins[] = {
 	MESON_PIN(GPIOX_19, EE_OFF),
 	MESON_PIN(GPIOX_20, EE_OFF),
 	MESON_PIN(GPIOX_21, EE_OFF),
-	MESON_PIN(GPIOX_22, EE_OFF),
 
 	MESON_PIN(GPIOCLK_0, EE_OFF),
 	MESON_PIN(GPIOCLK_1, EE_OFF),
-- 
2.13.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] pinctrl: meson-gxbb: remove non-existing pin GPIOX_22
  2017-06-07  5:44 [PATCH] pinctrl: meson-gxbb: remove non-existing pin GPIOX_22 Heiner Kallweit
@ 2017-06-07 11:27 ` Neil Armstrong
  2017-06-09  7:25 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2017-06-07 11:27 UTC (permalink / raw)
  To: linus-amlogic

On 06/07/2017 07:44 AM, Heiner Kallweit wrote:
> After commit 34e61801a3b9 "pinctrl: meson-gxbb: Add missing GPIODV_18
> pin entry" I started to get the following warning:
> 
> "meson-pinctrl c8834000.periphs:pinctrl at 4b0: names 119 do not match
> number of GPIOs 120"
> 
> It turned out that not the mentioned commit has a problem, it just
> revealed another problem which had existed before.
> 
> There is no PIN GPIOX_22 on Meson GXBB.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index 8b716b93..a879cf07 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -138,7 +138,6 @@ static const struct pinctrl_pin_desc meson_gxbb_periphs_pins[] = {
>  	MESON_PIN(GPIOX_19, EE_OFF),
>  	MESON_PIN(GPIOX_20, EE_OFF),
>  	MESON_PIN(GPIOX_21, EE_OFF),
> -	MESON_PIN(GPIOX_22, EE_OFF),
>  
>  	MESON_PIN(GPIOCLK_0, EE_OFF),
>  	MESON_PIN(GPIOCLK_1, EE_OFF),
> 

Fixes: 468c234f9ed7 ("pinctrl: amlogic: Add support for Amlogic Meson GXBB SoC")
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Thanks for the patch !

Neil

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] pinctrl: meson-gxbb: remove non-existing pin GPIOX_22
  2017-06-07  5:44 [PATCH] pinctrl: meson-gxbb: remove non-existing pin GPIOX_22 Heiner Kallweit
  2017-06-07 11:27 ` Neil Armstrong
@ 2017-06-09  7:25 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-06-09  7:25 UTC (permalink / raw)
  To: linus-amlogic

On Wed, Jun 7, 2017 at 7:44 AM, Heiner Kallweit <hkallweit1@gmail.com> wrote:

> After commit 34e61801a3b9 "pinctrl: meson-gxbb: Add missing GPIODV_18
> pin entry" I started to get the following warning:
>
> "meson-pinctrl c8834000.periphs:pinctrl at 4b0: names 119 do not match
> number of GPIOs 120"
>
> It turned out that not the mentioned commit has a problem, it just
> revealed another problem which had existed before.
>
> There is no PIN GPIOX_22 on Meson GXBB.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Patch applied with Neil's tags.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-09  7:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-07  5:44 [PATCH] pinctrl: meson-gxbb: remove non-existing pin GPIOX_22 Heiner Kallweit
2017-06-07 11:27 ` Neil Armstrong
2017-06-09  7:25 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®