[PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[Huqiang Qin]

Add watchdog device.

Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
---
 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
index 998f5050795c..106f4dd09a1b 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
@@ -81,6 +81,12 @@ apb4: bus@fe000000 {
 			#size-cells = <2>;
 			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
 
+			watchdog@2100 {
+				compatible = "amlogic,t7-wdt";
+				reg = <0x0 0x2100 0x0 0x10>;
+				clocks = <&xtal>;
+			};
+
 			periphs_pinctrl: pinctrl@4000 {
 				compatible = "amlogic,c3-periphs-pinctrl";
 				#address-cells = <2>;

base-commit: 8fff9184d1b5810dca5dd1a02726d4f844af88fc
-- 
2.42.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[Krzysztof Kozlowski]

On 25/09/2023 11:06, Huqiang Qin wrote:
> Add watchdog device.
> 
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> ---
>  arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> index 998f5050795c..106f4dd09a1b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> @@ -81,6 +81,12 @@ apb4: bus@fe000000 {
>  			#size-cells = <2>;
>  			ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>  
> +			watchdog@2100 {
> +				compatible = "amlogic,t7-wdt";

This is c3, not t7. Why do you use t7 compatible alone?

Best regards,
Krzysztof


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[Huqiang Qin]

Hi Krzysztof,

On 2023/9/25 17:33, Krzysztof Kozlowski wrote:
> This is c3, not t7. Why do you use t7 compatible alone?

The C3 and T7 use the same watchdog controller, so they are compatible.

Best regards,
Huqiang Qin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[Krzysztof Kozlowski]

On 25/09/2023 12:42, Huqiang Qin wrote:
> Hi Krzysztof,
> 
> On 2023/9/25 17:33, Krzysztof Kozlowski wrote:
>> This is c3, not t7. Why do you use t7 compatible alone?
> 
> The C3 and T7 use the same watchdog controller, so they are compatible.

I am not saying that they are not compatible. I am saying that different
SoCs should use the same compatible. Just like for every other platform,
Amlogic is not special here.

https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst

Best regards,
Krzysztof


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[Krzysztof Kozlowski]

On 25/09/2023 12:45, Krzysztof Kozlowski wrote:
> On 25/09/2023 12:42, Huqiang Qin wrote:
>> Hi Krzysztof,
>>
>> On 2023/9/25 17:33, Krzysztof Kozlowski wrote:
>>> This is c3, not t7. Why do you use t7 compatible alone?
>>
>> The C3 and T7 use the same watchdog controller, so they are compatible.
> 
> I am not saying that they are not compatible. I am saying that different
> SoCs should use the same compatible. Just like for every other platform,

Eh, missing "not", so "should not use":

I am not saying that they are not compatible. I am saying that different
SoCs should not use the same compatible. Just like for every other
platform, Amlogic is not special here.

> Amlogic is not special here.
> 
> https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst

Please define compatibility list with t7 as fallback.

Best regards,
Krzysztof


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: Add watchdog node for Amlogic-C3 SoCs

[Huqiang Qin]

On 2023/9/25 18:58, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 25/09/2023 12:45, Krzysztof Kozlowski wrote:
>> On 25/09/2023 12:42, Huqiang Qin wrote:
>>> Hi Krzysztof,
>>>
>>> On 2023/9/25 17:33, Krzysztof Kozlowski wrote:
>>>> This is c3, not t7. Why do you use t7 compatible alone?
>>>
>>> The C3 and T7 use the same watchdog controller, so they are compatible.
>>
>> I am not saying that they are not compatible. I am saying that different
>> SoCs should use the same compatible. Just like for every other platform,
> 
> Eh, missing "not", so "should not use":
> 
> I am not saying that they are not compatible. I am saying that different
> SoCs should not use the same compatible. Just like for every other
> platform, Amlogic is not special here.
> 
>> Amlogic is not special here.
>>
>> https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst
> 
> Please define compatibility list with t7 as fallback.

Okay, got it, I will modify it in the next version.

Thanks


Best regards,
Huqiang Qin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic