From: neil.armstrong@linaro.org
To: Pierre-Olivier Mercier <nemunaire@nemunai.re>,
martin.blumenstingl@googlemail.com
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"
Date: Thu, 5 Jan 2023 18:52:00 +0100 [thread overview]
Message-ID: <dfeff261-53cf-54b5-b3dd-dc0ce0d1e6a0@linaro.org> (raw)
In-Reply-To: <20230105120206.28964-1-nemunaire@nemunai.re>
On 05/01/2023 13:02, Pierre-Olivier Mercier wrote:
> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
>
> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
> need to be enabled. This is inherited from the GLX USB design [1].
>
> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
>
> Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
> ---
> v2:
> - Fix commit log
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index e3486f60645a..a1f0c38ccadd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -131,10 +131,6 @@ flash@0 {
> };
>
> &usb {
> - phys = <&usb2_phy1>;
> - phy-names = "usb2-phy1";
> -};
> -
> -&usb2_phy0 {
> - status = "disabled";
> + phys = <&usb2_phy0>, <&usb2_phy1>;
> + phy-names = "usb2-phy0", "usb2-phy1";
> };
OK weird, this email doesn't appear on any mailing-lists archive, neither our replies !
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-05 20:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 22:48 [BISECTED] arm64: dts: meson-sm1-odroid-hc4: USB not working Pierre-Olivier Mercier
2022-12-27 10:43 ` Martin Blumenstingl
2023-01-02 9:50 ` Neil Armstrong
2023-01-04 14:06 ` [PATCH] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0" Pierre-Olivier Mercier
2023-01-05 10:29 ` neil.armstrong
2023-01-05 12:02 ` [PATCH v2] " Pierre-Olivier Mercier
2023-01-05 13:57 ` neil.armstrong
2023-01-05 17:15 ` Martin Blumenstingl
2023-01-05 17:52 ` neil.armstrong [this message]
2023-01-06 8:13 ` Neil Armstrong
2023-01-06 8:03 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfeff261-53cf-54b5-b3dd-dc0ce0d1e6a0@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nemunaire@nemunai.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®