[BISECTED] arm64: dts: meson-sm1-odroid-hc4: USB not working

[BISECTED] arm64: dts: meson-sm1-odroid-hc4: USB not working

[Pierre-Olivier Mercier]

Hi,

On my Odroid-HC4, the USB 2.0 port (the only one available) was not
working. While it seems I was not the only one in that case[1], after
some experiments, I found that by reverting the following commit:

703e84d6615a4 arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0

it solves the issue: USB is working on latest stable (6.1.1) with this
only patch reverted, while it doesn't with vanilla dtb (with same
config otherwise).


Here are the logs with the patch untouched:

[    1.422947] dwc3-meson-g12a ffe09000.usb: USB2 ports: 1
[    1.426394] dwc3-meson-g12a ffe09000.usb: USB3 ports: 0
[    1.433413] dwc2 ff400000.usb: supply vusb_d not found, using dummy regulator
[    1.438739] dwc2 ff400000.usb: supply vusb_a not found, using dummy regulator
[    1.445913] dwc2 ff400000.usb: EPs: 7, dedicated fifos, 712 entries in SPRAM
[    1.453859] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[    1.458153] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 1
[    1.465848] xhci-hcd xhci-hcd.1.auto: hcc params 0x0228fe64 hci version 0x110 quirks 0x0000000000010010
[    1.475062] xhci-hcd xhci-hcd.1.auto: irq 18, io mem 0xff500000
[    1.481028] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[    1.486333] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 2
[    1.493931] xhci-hcd xhci-hcd.1.auto: Host supports USB 3.0 SuperSpeed
[    1.500710] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.01
[    1.508616] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[    1.515736] usb usb1: Product: xHCI Host Controller
[    1.520563] usb usb1: Manufacturer: Linux 6.1.1-nemunaire xhci-hcd
[    1.526687] usb usb1: SerialNumber: xhci-hcd.1.auto
[    1.531973] hub 1-0:1.0: USB hub found
[    1.540413] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM.
[    1.547374] usb usb2: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 6.01
[    1.555417] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[    1.562588] usb usb2: Product: xHCI Host Controller
[    1.567397] usb usb2: Manufacturer: Linux 6.1.1-nemunaire xhci-hcd
[    1.573520] usb usb2: SerialNumber: xhci-hcd.1.auto
[    1.578780] hub 2-0:1.0: USB hub found
[    4.565412] usb usb1-port2: connect-debounce failed


With the patch reverted:

[    1.432476] dwc3-meson-g12a ffe09000.usb: USB2 ports: 2
[    1.435820] dwc3-meson-g12a ffe09000.usb: USB3 ports: 0
[    1.443953] dwc2 ff400000.usb: supply vusb_d not found, using dummy regulator
[    1.448187] dwc2 ff400000.usb: supply vusb_a not found, using dummy regulator
[    1.455361] dwc2 ff400000.usb: EPs: 7, dedicated fifos, 712 entries in SPRAM
[    1.463273] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[    1.467576] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 1
[    1.475268] xhci-hcd xhci-hcd.1.auto: hcc params 0x0228fe64 hci version 0x110 quirks 0x0000000000010010
[    1.484508] xhci-hcd xhci-hcd.1.auto: irq 18, io mem 0xff500000
[    1.490451] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[    1.495756] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 2
[    1.503345] xhci-hcd xhci-hcd.1.auto: Host supports USB 3.0 SuperSpeed
[    1.510032] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 6.01
[    1.518009] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[    1.525160] usb usb1: Product: xHCI Host Controller
[    1.529987] usb usb1: Manufacturer: Linux 6.1.1-nemunaire xhci-hcd
[    1.536111] usb usb1: SerialNumber: xhci-hcd.1.auto
[    1.541393] hub 1-0:1.0: USB hub found
[    1.549091] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM.
[    1.556810] usb usb2: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 6.01
[    1.564844] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1
[    1.571996] usb usb2: Product: xHCI Host Controller
[    1.576821] usb usb2: Manufacturer: Linux 6.1.1-nemunaire xhci-hcd
[    1.582945] usb usb2: SerialNumber: xhci-hcd.1.auto
[    1.588238] hub 2-0:1.0: USB hub found
[    1.806067] usb 1-2: new full-speed USB device number 2 using xhci-hcd
[    1.982226] usb 1-2: New USB device found, idVendor=9e88, idProduct=9e8f, bcdDevice= 5.00
[    1.984769] usb 1-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[...]


I didn't read the specs, but I also tried to inverse the patch (disable
usb2_phy1 intead of usb2_phy0) and it didn't work neither. Apparently
usb2_phy0 and usb2_phy1 are both required for some reason...

Could you reconsider this dts change?

[1]: https://www.reddit.com/r/ODroid/comments/wcrdeq/usb_port_not_working_on_hc4/ 

-- 
Pierre-Olivier "nemunaire" Mercier

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [BISECTED] arm64: dts: meson-sm1-odroid-hc4: USB not working

[Martin Blumenstingl]

Hi Pierre-Olivier, Hi Neil,

On Mon, Dec 26, 2022 at 11:48 PM Pierre-Olivier Mercier
<nemunaire@nemunai.re> wrote:
>
> Hi,
>
> On my Odroid-HC4, the USB 2.0 port (the only one available) was not
> working. While it seems I was not the only one in that case[1], after
> some experiments, I found that by reverting the following commit:
>
> 703e84d6615a4 arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0
Thank you for bisecting the commit!

> it solves the issue: USB is working on latest stable (6.1.1) with this
> only patch reverted, while it doesn't with vanilla dtb (with same
> config otherwise).
[...]
> I didn't read the specs, but I also tried to inverse the patch (disable
> usb2_phy1 intead of usb2_phy0) and it didn't work neither. Apparently
> usb2_phy0 and usb2_phy1 are both required for some reason...
After reading this mail yesterday I could not make much sense of it.
Now, while re-reading it I remembered the time when I worked on GXL
USB support and wrote the following comment: [0]
  All USB2 PHYs (which are internally "connected" to the dwc3 roothub)
  need to be powered on, otherwise USB devices cannot be
  enumerated (even if just one PHY is disabled and if the device is
  plugged into another, enabled port)

This is probably also the reason why I left all USB PHYs enabled by
default in meson-{gxl,gxm}.dtsi (and so did we in
meson-g12-common.dtsi). Instead we're disabling the &usb node by
default (and enabling it for boards that have USB ports).
For readers not familiar with the default enabled/disabled: typically
we disable the nodes for IP blocks in the .dtsi and then each
board.dts enables them on demand.

Neil, what do you think about this?
Should Pierre-Olivier send a formal revert (with the problem being
described as part of the git commit message, such as in [1])?


PS: Neil has probably taken some days off, so please give him more
than usual time to reply.


Best regards,
Martin


[0] https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=47722220660cfb935e27e62d385959ecc296cddb

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [BISECTED] arm64: dts: meson-sm1-odroid-hc4: USB not working

[Neil Armstrong]

On 27/12/2022 11:43, Martin Blumenstingl wrote:
> Hi Pierre-Olivier, Hi Neil,
> 
> On Mon, Dec 26, 2022 at 11:48 PM Pierre-Olivier Mercier
> <nemunaire@nemunai.re> wrote:
>>
>> Hi,
>>
>> On my Odroid-HC4, the USB 2.0 port (the only one available) was not
>> working. While it seems I was not the only one in that case[1], after
>> some experiments, I found that by reverting the following commit:
>>
>> 703e84d6615a4 arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0
> Thank you for bisecting the commit!
> 
>> it solves the issue: USB is working on latest stable (6.1.1) with this
>> only patch reverted, while it doesn't with vanilla dtb (with same
>> config otherwise).
> [...]
>> I didn't read the specs, but I also tried to inverse the patch (disable
>> usb2_phy1 intead of usb2_phy0) and it didn't work neither. Apparently
>> usb2_phy0 and usb2_phy1 are both required for some reason...
> After reading this mail yesterday I could not make much sense of it.
> Now, while re-reading it I remembered the time when I worked on GXL
> USB support and wrote the following comment: [0]
>    All USB2 PHYs (which are internally "connected" to the dwc3 roothub)
>    need to be powered on, otherwise USB devices cannot be
>    enumerated (even if just one PHY is disabled and if the device is
>    plugged into another, enabled port)
> 
> This is probably also the reason why I left all USB PHYs enabled by
> default in meson-{gxl,gxm}.dtsi (and so did we in
> meson-g12-common.dtsi). Instead we're disabling the &usb node by
> default (and enabling it for boards that have USB ports).
> For readers not familiar with the default enabled/disabled: typically
> we disable the nodes for IP blocks in the .dtsi and then each
> board.dts enables them on demand.
> 
> Neil, what do you think about this?
> Should Pierre-Olivier send a formal revert (with the problem being
> described as part of the git commit message, such as in [1])?

It's true I haven't tested with only a single USB2 phy enabled, but
since the USB design is a derivative from GXL both USB2 PHYs should be
powered on for USB to work.

Pierre-Olivier, can you send a proper revert patch so I can apply it
to fixes and send it asap ?

Thanks for the report !

Neil

> 
> 
> PS: Neil has probably taken some days off, so please give him more
> than usual time to reply.
> 
> 
> Best regards,
> Martin
> 
> 
> [0] https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=47722220660cfb935e27e62d385959ecc296cddb


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[PATCH] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[Pierre-Olivier Mercier]

This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.

USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
need to be enabled. This is inherited from the GLX USB design [0].

[0]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
Link: https://lore.kernel.org/all/Y6okoXpwF%2FLZewhv@nemunai.re/
Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
index e3486f60645a..a1f0c38ccadd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
@@ -131,10 +131,6 @@ flash@0 {
 };
 
 &usb {
-	phys = <&usb2_phy1>;
-	phy-names = "usb2-phy1";
-};
-
-&usb2_phy0 {
-	status = "disabled";
+	phys = <&usb2_phy0>, <&usb2_phy1>;
+	phy-names = "usb2-phy0", "usb2-phy1";
 };
-- 
2.38.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[neil.armstrong]

On 04/01/2023 15:06, Pierre-Olivier Mercier wrote:
> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
> 
> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
> need to be enabled. This is inherited from the GLX USB design [0].
> 
> [0]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
> Link: https://lore.kernel.org/all/Y6okoXpwF%2FLZewhv@nemunai.re/

This should be [1] and referenced in the commit message, Link: will be used
with the applied patch URL.

> Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
> ---
>   arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index e3486f60645a..a1f0c38ccadd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -131,10 +131,6 @@ flash@0 {
>   };
>   
>   &usb {
> -	phys = <&usb2_phy1>;
> -	phy-names = "usb2-phy1";
> -};
> -
> -&usb2_phy0 {
> -	status = "disabled";
> +	phys = <&usb2_phy0>, <&usb2_phy1>;
> +	phy-names = "usb2-phy0", "usb2-phy1";
>   };

With the commit log fixed:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks !
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[Pierre-Olivier Mercier]

This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.

USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
need to be enabled. This is inherited from the GLX USB design [1].

[1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/

Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
---
v2:
 - Fix commit log
---
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
index e3486f60645a..a1f0c38ccadd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
@@ -131,10 +131,6 @@ flash@0 {
 };
 
 &usb {
-	phys = <&usb2_phy1>;
-	phy-names = "usb2-phy1";
-};
-
-&usb2_phy0 {
-	status = "disabled";
+	phys = <&usb2_phy0>, <&usb2_phy1>;
+	phy-names = "usb2-phy0", "usb2-phy1";
 };
-- 
2.38.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[neil.armstrong]

On 05/01/2023 13:02, Pierre-Olivier Mercier wrote:
> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
> 
> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
> need to be enabled. This is inherited from the GLX USB design [1].
> 
> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
> 
> Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
> ---
> v2:
>   - Fix commit log
> ---
>   arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index e3486f60645a..a1f0c38ccadd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -131,10 +131,6 @@ flash@0 {
>   };
>   
>   &usb {
> -	phys = <&usb2_phy1>;
> -	phy-names = "usb2-phy1";
> -};
> -
> -&usb2_phy0 {
> -	status = "disabled";
> +	phys = <&usb2_phy0>, <&usb2_phy1>;
> +	phy-names = "usb2-phy0", "usb2-phy1";
>   };

Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[Martin Blumenstingl]

On Thu, Jan 5, 2023 at 1:06 PM Pierre-Olivier Mercier
<nemunaire@nemunai.re> wrote:
>
> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
>
> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
> need to be enabled. This is inherited from the GLX USB design [1].
>
> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
>
> Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[neil.armstrong]

On 05/01/2023 13:02, Pierre-Olivier Mercier wrote:
> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
> 
> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
> need to be enabled. This is inherited from the GLX USB design [1].
> 
> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
> 
> Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
> ---
> v2:
>   - Fix commit log
> ---
>   arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index e3486f60645a..a1f0c38ccadd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -131,10 +131,6 @@ flash@0 {
>   };
>   
>   &usb {
> -	phys = <&usb2_phy1>;
> -	phy-names = "usb2-phy1";
> -};
> -
> -&usb2_phy0 {
> -	status = "disabled";
> +	phys = <&usb2_phy0>, <&usb2_phy1>;
> +	phy-names = "usb2-phy0", "usb2-phy1";
>   };

OK weird, this email doesn't appear on any mailing-lists archive, neither our replies !

Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[Neil Armstrong]

Hi,

On Thu, 05 Jan 2023 13:02:08 +0100, Pierre-Olivier Mercier wrote:
> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
> 
> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
> need to be enabled. This is inherited from the GLX USB design [1].
> 
> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.2/fixes)

[1/1] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"
      https://git.kernel.org/amlogic/c/c45219cba101f32853d011da2ba46a1b2338dc4c

These changes has been applied on the intermediate git tree [1].

The v6.2/fixes branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2] Revert "arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0"

[Neil Armstrong]

On 05/01/2023 18:52, neil.armstrong@linaro.org wrote:
> On 05/01/2023 13:02, Pierre-Olivier Mercier wrote:
>> This reverts commit 703e84d6615a4a95fb504c8f2e4c9426b86f3930.
>>
>> USB device enumeration was not working on Odroid HC4 as both USB2 PHYs
>> need to be enabled. This is inherited from the GLX USB design [1].
>>
>> [1]: https://lore.kernel.org/all/20170814224542.18257-1-martin.blumenstingl@googlemail.com/T/
>>
>> Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
>> ---
>> v2:
>>   - Fix commit log
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 8 ++------
>>   1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
>> index e3486f60645a..a1f0c38ccadd 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
>> @@ -131,10 +131,6 @@ flash@0 {
>>   };
>>   &usb {
>> -    phys = <&usb2_phy1>;
>> -    phy-names = "usb2-phy1";
>> -};
>> -
>> -&usb2_phy0 {
>> -    status = "disabled";
>> +    phys = <&usb2_phy0>, <&usb2_phy1>;
>> +    phy-names = "usb2-phy0", "usb2-phy1";
>>   };
> 
> OK weird, this email doesn't appear on any mailing-lists archive, neither our replies !

Seems infradead was struggling yesterday, everything is back to normal and revert is sent to SoC maintainers.

> 
> Neil


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic