From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes
Date: Mon, 30 Dec 2024 10:55:29 +0100 [thread overview]
Message-ID: <e08e5be6-9d0e-4d32-9d67-eec57634f6db@linaro.org> (raw)
In-Reply-To: <20241226220352.965505-1-martin.blumenstingl@googlemail.com>
On 26/12/2024 23:03, Martin Blumenstingl wrote:
> The only board that actually requires these properties is
> meson8b-odroidc1.dts but that already sets it on it's own. Drop these
> properties from meson.dtsi because otherwise they can cause dtc
> warnings:
> /soc/usb@c9040000: unnecessary #address-cells/#size-cells without
> "ranges", "dma-ranges" or child "reg" property
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/amlogic/meson.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/amlogic/meson.dtsi b/arch/arm/boot/dts/amlogic/meson.dtsi
> index 8cb0fc78b2af..28ec2c821cdc 100644
> --- a/arch/arm/boot/dts/amlogic/meson.dtsi
> +++ b/arch/arm/boot/dts/amlogic/meson.dtsi
> @@ -255,8 +255,6 @@ rtc: rtc@740 {
>
> usb0: usb@c9040000 {
> compatible = "snps,dwc2";
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0xc9040000 0x40000>;
> interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb0_phy>;
> @@ -270,8 +268,6 @@ usb0: usb@c9040000 {
>
> usb1: usb@c90c0000 {
> compatible = "snps,dwc2";
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0xc90c0000 0x40000>;
> interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usb1_phy>;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-12-30 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 22:03 Martin Blumenstingl
2024-12-30 9:55 ` neil.armstrong [this message]
2024-12-30 10:00 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08e5be6-9d0e-4d32-9d67-eec57634f6db@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®