mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes
@ 2024-12-26 22:03 Martin Blumenstingl
  2024-12-30  9:55 ` neil.armstrong
  2024-12-30 10:00 ` Neil Armstrong
  0 siblings, 2 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2024-12-26 22:03 UTC (permalink / raw)
  To: linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, devicetree, neil.armstrong,
	Martin Blumenstingl

The only board that actually requires these properties is
meson8b-odroidc1.dts but that already sets it on it's own. Drop these
properties from meson.dtsi because otherwise they can cause dtc
warnings:
  /soc/usb@c9040000: unnecessary #address-cells/#size-cells without
  "ranges", "dma-ranges" or child "reg" property

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm/boot/dts/amlogic/meson.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/amlogic/meson.dtsi b/arch/arm/boot/dts/amlogic/meson.dtsi
index 8cb0fc78b2af..28ec2c821cdc 100644
--- a/arch/arm/boot/dts/amlogic/meson.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson.dtsi
@@ -255,8 +255,6 @@ rtc: rtc@740 {
 
 		usb0: usb@c9040000 {
 			compatible = "snps,dwc2";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			reg = <0xc9040000 0x40000>;
 			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
 			phys = <&usb0_phy>;
@@ -270,8 +268,6 @@ usb0: usb@c9040000 {
 
 		usb1: usb@c90c0000 {
 			compatible = "snps,dwc2";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			reg = <0xc90c0000 0x40000>;
 			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
 			phys = <&usb1_phy>;
-- 
2.47.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes
  2024-12-26 22:03 [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes Martin Blumenstingl
@ 2024-12-30  9:55 ` neil.armstrong
  2024-12-30 10:00 ` Neil Armstrong
  1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2024-12-30  9:55 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: linux-arm-kernel, linux-kernel, devicetree

On 26/12/2024 23:03, Martin Blumenstingl wrote:
> The only board that actually requires these properties is
> meson8b-odroidc1.dts but that already sets it on it's own. Drop these
> properties from meson.dtsi because otherwise they can cause dtc
> warnings:
>    /soc/usb@c9040000: unnecessary #address-cells/#size-cells without
>    "ranges", "dma-ranges" or child "reg" property
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>   arch/arm/boot/dts/amlogic/meson.dtsi | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/amlogic/meson.dtsi b/arch/arm/boot/dts/amlogic/meson.dtsi
> index 8cb0fc78b2af..28ec2c821cdc 100644
> --- a/arch/arm/boot/dts/amlogic/meson.dtsi
> +++ b/arch/arm/boot/dts/amlogic/meson.dtsi
> @@ -255,8 +255,6 @@ rtc: rtc@740 {
>   
>   		usb0: usb@c9040000 {
>   			compatible = "snps,dwc2";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>   			reg = <0xc9040000 0x40000>;
>   			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>   			phys = <&usb0_phy>;
> @@ -270,8 +268,6 @@ usb0: usb@c9040000 {
>   
>   		usb1: usb@c90c0000 {
>   			compatible = "snps,dwc2";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>   			reg = <0xc90c0000 0x40000>;
>   			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
>   			phys = <&usb1_phy>;

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes
  2024-12-26 22:03 [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes Martin Blumenstingl
  2024-12-30  9:55 ` neil.armstrong
@ 2024-12-30 10:00 ` Neil Armstrong
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-12-30 10:00 UTC (permalink / raw)
  To: linux-amlogic, Martin Blumenstingl
  Cc: linux-arm-kernel, linux-kernel, devicetree

Hi,

On Thu, 26 Dec 2024 23:03:52 +0100, Martin Blumenstingl wrote:
> The only board that actually requires these properties is
> meson8b-odroidc1.dts but that already sets it on it's own. Drop these
> properties from meson.dtsi because otherwise they can cause dtc
> warnings:
>   /soc/usb@c9040000: unnecessary #address-cells/#size-cells without
>   "ranges", "dma-ranges" or child "reg" property
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.14/arm-dt)

[1/1] ARM: dts: amlogic: meson: remove size and address cells from USB nodes
      https://git.kernel.org/amlogic/c/3a4bb81850662bebab74f1ad27071652b1825d58

These changes has been applied on the intermediate git tree [1].

The v6.14/arm-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-30 10:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-26 22:03 [PATCH] ARM: dts: amlogic: meson: remove size and address cells from USB nodes Martin Blumenstingl
2024-12-30  9:55 ` neil.armstrong
2024-12-30 10:00 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®