* [f2fs-dev] [PATCH] f2fs: remove unnecessary TestClearPageError when wait pages writeback
@ 2013-11-04 2:28 Chao Yu
0 siblings, 0 replies; only message in thread
From: Chao Yu @ 2013-11-04 2:28 UTC (permalink / raw)
To: 'Jaegeuk Kim'
Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel, 谭姝
In wait_on_node_pages_writeback we will test and clear error flag for all pages in radix tree, but not necessary.
So we only do this for pages belong to the specified inode.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
fs/f2fs/node.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index b527ed4..4ac4150 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1170,10 +1170,11 @@ int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino)
if (page->index > end)
continue;
- if (ino && ino_of_node(page) == ino)
+ if (ino && ino_of_node(page) == ino) {
wait_on_page_writeback(page);
- if (TestClearPageError(page))
- ret = -EIO;
+ if (TestClearPageError(page))
+ ret = -EIO;
+ }
}
pagevec_release(&pvec);
cond_resched();
--
1.7.9.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-04 2:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-04 2:28 [f2fs-dev] [PATCH] f2fs: remove unnecessary TestClearPageError when wait pages writeback Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome