* [PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound system
@ 2018-03-19 1:21 Katsuhiro Suzuki
2018-03-19 14:35 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Katsuhiro Suzuki @ 2018-03-19 1:21 UTC (permalink / raw)
To: linux-arm-kernel, Masahiro Yamada, devicetree
Cc: Masami Hiramatsu, Jassi Brar, linux-kernel, Katsuhiro Suzuki
This patch adds syscon property for specifying soc-glue core into
device-tree of LD11/LD20 SoC.
Currently, soc-glue core is used for changing the state of S/PDIF
signal output pin to signal output state or Hi-Z state.
Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
---
arch/arm/boot/dts/uniphier-pxs2.dtsi | 4 +++-
arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 4 +++-
arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 4 +++-
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/uniphier-pxs2.dtsi b/arch/arm/boot/dts/uniphier-pxs2.dtsi
index 595045441c9c..c72c0a123c87 100644
--- a/arch/arm/boot/dts/uniphier-pxs2.dtsi
+++ b/arch/arm/boot/dts/uniphier-pxs2.dtsi
@@ -243,6 +243,8 @@
resets = <&sys_rst 40>;
#sound-dai-cells = <1>;
+ socionext,syscon = <&sg>;
+
i2s_port0: port@0 {
i2s_hdmi: endpoint {
};
@@ -418,7 +420,7 @@
};
};
- soc-glue@5f800000 {
+ sg: soc-glue@5f800000 {
compatible = "socionext,uniphier-pxs2-soc-glue",
"simple-mfd", "syscon";
reg = <0x5f800000 0x2000>;
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi
index efa95573b2aa..5a1b8d574904 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi
@@ -198,6 +198,8 @@
resets = <&sys_rst 40>;
#sound-dai-cells = <1>;
+ socionext,syscon = <&sg>;
+
i2s_port0: port@0 {
i2s_hdmi: endpoint {
};
@@ -479,7 +481,7 @@
};
};
- soc-glue@5f800000 {
+ sg: soc-glue@5f800000 {
compatible = "socionext,uniphier-ld11-soc-glue",
"simple-mfd", "syscon";
reg = <0x5f800000 0x2000>;
diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
index 19c935688a77..831522444276 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
@@ -298,6 +298,8 @@
resets = <&sys_rst 40>;
#sound-dai-cells = <1>;
+ socionext,syscon = <&sg>;
+
i2s_port0: port@0 {
i2s_hdmi: endpoint {
};
@@ -525,7 +527,7 @@
cdns,phy-dll-delay-sdclk-hsmmc = <21>;
};
- soc-glue@5f800000 {
+ sg: soc-glue@5f800000 {
compatible = "socionext,uniphier-ld20-soc-glue",
"simple-mfd", "syscon";
reg = <0x5f800000 0x2000>;
--
2.16.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound system
2018-03-19 1:21 [PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound system Katsuhiro Suzuki
@ 2018-03-19 14:35 ` Masahiro Yamada
2018-03-20 0:50 ` Katsuhiro Suzuki
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2018-03-19 14:35 UTC (permalink / raw)
To: Katsuhiro Suzuki
Cc: linux-arm-kernel, devicetree, Masami Hiramatsu, Jassi Brar,
Linux Kernel Mailing List
2018-03-19 10:21 GMT+09:00 Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>:
> This patch adds syscon property for specifying soc-glue core into
> device-tree of LD11/LD20 SoC.
>
> Currently, soc-glue core is used for changing the state of S/PDIF
> signal output pin to signal output state or Hi-Z state.
>
> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> ---
> arch/arm/boot/dts/uniphier-pxs2.dtsi | 4 +++-
Please split PXs2 changes into a different patch.
> arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 4 +++-
> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 4 +++-
> 3 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/uniphier-pxs2.dtsi b/arch/arm/boot/dts/uniphier-pxs2.dtsi
> index 595045441c9c..c72c0a123c87 100644
> --- a/arch/arm/boot/dts/uniphier-pxs2.dtsi
> +++ b/arch/arm/boot/dts/uniphier-pxs2.dtsi
> @@ -243,6 +243,8 @@
> resets = <&sys_rst 40>;
> #sound-dai-cells = <1>;
>
> + socionext,syscon = <&sg>;
Remove unneeded blank line between properties.
> +
> i2s_port0: port@0 {
> i2s_hdmi: endpoint {
> };
> @@ -418,7 +420,7 @@
> };
> };
>
> - soc-glue@5f800000 {
> + sg: soc-glue@5f800000 {
> compatible = "socionext,uniphier-pxs2-soc-glue",
> "simple-mfd", "syscon";
> reg = <0x5f800000 0x2000>;
Could you use 'soc_glue', please?
I saw a conflict between 'sg' and 'soc_glue' among Socionext engineers
and I prefer the latter.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound system
2018-03-19 14:35 ` Masahiro Yamada
@ 2018-03-20 0:50 ` Katsuhiro Suzuki
0 siblings, 0 replies; 3+ messages in thread
From: Katsuhiro Suzuki @ 2018-03-20 0:50 UTC (permalink / raw)
To: 'Masahiro Yamada',
Suzuki, Katsuhiro/鈴木 勝博
Cc: linux-arm-kernel, devicetree, Masami Hiramatsu, Jassi Brar,
Linux Kernel Mailing List
Hello Yamada-san,
Thank you for reviewing.
> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]
> Sent: Monday, March 19, 2018 11:36 PM
> To: Suzuki, Katsuhiro <suzuki.katsuhiro@socionext.com>
> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>;
> devicetree@vger.kernel.org; Masami Hiramatsu <masami.hiramatsu@linaro.org>; Jassi
> Brar <jaswinder.singh@linaro.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound
> system
>
> 2018-03-19 10:21 GMT+09:00 Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>:
> > This patch adds syscon property for specifying soc-glue core into
> > device-tree of LD11/LD20 SoC.
> >
> > Currently, soc-glue core is used for changing the state of S/PDIF
> > signal output pin to signal output state or Hi-Z state.
> >
> > Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> > ---
> > arch/arm/boot/dts/uniphier-pxs2.dtsi | 4 +++-
>
>
> Please split PXs2 changes into a different patch.
>
>
> > arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 4 +++-
> > arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 4 +++-
> > 3 files changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/uniphier-pxs2.dtsi
> b/arch/arm/boot/dts/uniphier-pxs2.dtsi
> > index 595045441c9c..c72c0a123c87 100644
> > --- a/arch/arm/boot/dts/uniphier-pxs2.dtsi
> > +++ b/arch/arm/boot/dts/uniphier-pxs2.dtsi
> > @@ -243,6 +243,8 @@
> > resets = <&sys_rst 40>;
> > #sound-dai-cells = <1>;
> >
> > + socionext,syscon = <&sg>;
>
>
> Remove unneeded blank line between properties.
>
>
> > +
> > i2s_port0: port@0 {
> > i2s_hdmi: endpoint {
> > };
> > @@ -418,7 +420,7 @@
> > };
> > };
> >
> > - soc-glue@5f800000 {
> > + sg: soc-glue@5f800000 {
> > compatible = "socionext,uniphier-pxs2-soc-glue",
> > "simple-mfd", "syscon";
> > reg = <0x5f800000 0x2000>;
>
>
> Could you use 'soc_glue', please?
> I saw a conflict between 'sg' and 'soc_glue' among Socionext engineers
> and I prefer the latter.
I see, I'll fix and send v2 series.
Regards,
--
Katsuhiro Suzuki
>
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-20 0:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 1:21 [PATCH] arm64: dts: uniphier: add syscon property for UniPhier sound system Katsuhiro Suzuki
2018-03-19 14:35 ` Masahiro Yamada
2018-03-20 0:50 ` Katsuhiro Suzuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®