From: "hoyoung seo" <hy50.seo@samsung.com>
To: "'Christoph Hellwig'" <hch@infradead.org>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<beanhuo@micron.com>, <bvanassche@acm.org>,
<kwangwon.min@samsung.com>, <kwmad.kim@samsung.com>,
<cpgs@samsung.com>, <h10.kim@samsung.com>,
<willdeacon@google.com>, <jaegeuk@google.com>, <chao@kernel.org>,
<linux-fsdevel@vger.kernel.org>
Subject: RE: [PATCH v1] writback: remove WQ_MEM_RECLAIM flag in bdi_wq
Date: Mon, 21 Jul 2025 17:37:03 +0900 [thread overview]
Message-ID: <000001dbfa1a$a2a1ad80$e7e50880$@samsung.com> (raw)
In-Reply-To: <aH3on5GBd6AfgJuw@infradead.org>
> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: Monday, July 21, 2025 4:14 PM
> To: hy50.seo <hy50.seo@samsung.com>
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org;
> alim.akhtar@samsung.com; avri.altman@wdc.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; beanhuo@micron.com; bvanassche@acm.org;
> kwangwon.min@samsung.com; kwmad.kim@samsung.com; cpgs@samsung.com;
> h10.kim@samsung.com; willdeacon@google.com; jaegeuk@google.com;
> chao@kernel.org; linux-fsdevel@vger.kernel.org
> Subject: Re: [PATCH v1] writback: remove WQ_MEM_RECLAIM flag in bdi_wq
>
> On Mon, Jul 21, 2025 at 03:40:24PM +0900, hy50.seo wrote:
> > if it write with the write back option with f2fs, kernel panic occurs.
> > Because the write back function uses bdi_wq and WQ_MEM_RECLAIM flag is
> > included and created.
> > However, this function calls f2fs_do_quota() of f2fs and finally tries
> > to perform quota_release_work.
> > the quota_release_work is performed in the events_unbound workqueue,
> > but the WQ_MEM_RECLAIM flag is not included.
>
> And what makes you assume the WQ_MEM_RECLAIM was added just for fun and
> can simply be deleted?
No way..
It's because i just don't know much about this part.
And WQ_MEM_RECLAIM flag is absolutely necessary.
Because it is necessary for stable write back operation when memory is
insufficient.
is it right?
I'll find another way for fix bug.
Thanks for your reply.
next prev parent reply other threads:[~2025-07-21 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250721062037epcas2p25fd6fcf66914a419ceefca3285ea09f3@epcas2p2.samsung.com>
2025-07-21 6:40 ` hy50.seo
2025-07-21 7:13 ` Christoph Hellwig
2025-07-21 8:37 ` hoyoung seo [this message]
2025-07-22 5:59 ` 'Christoph Hellwig'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001dbfa1a$a2a1ad80$e7e50880$@samsung.com' \
--to=hy50.seo@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=chao@kernel.org \
--cc=cpgs@samsung.com \
--cc=h10.kim@samsung.com \
--cc=hch@infradead.org \
--cc=jaegeuk@google.com \
--cc=jejb@linux.ibm.com \
--cc=kwangwon.min@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=willdeacon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®