[PATCH 2/3] pinctrl: st: Staticize local symbols

[PATCH 2/3] pinctrl: st: Staticize local symbols

[Jingoo Han]

These local symbols are used only in this file.
Fix the following sparse warning:

drivers/pinctrl/pinctrl-st.c:291:14: warning: symbol 'stih415_input_delays' was not declared. Should it be static?
drivers/pinctrl/pinctrl-st.c:292:14: warning: symbol 'stih415_output_delays' was not declared. Should it be static?
drivers/pinctrl/pinctrl-st.c:327:14: warning: symbol 'stih416_delays' was not declared. Should it be static?
drivers/pinctrl/pinctrl-st.c:814:12: warning: symbol 'st_pmx_get_fname' was not declared. Should it be static?

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pinctrl/pinctrl-st.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 04d4506..acc2b1e 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -288,8 +288,8 @@ struct st_pinctrl {
 
 /* SOC specific data */
 /* STiH415 data */
-unsigned int stih415_input_delays[] = {0, 500, 1000, 1500};
-unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000};
+static unsigned int stih415_input_delays[] = {0, 500, 1000, 1500};
+static unsigned int stih415_output_delays[] = {0, 1000, 2000, 3000};
 
 #define STIH415_PCTRL_COMMON_DATA				\
 	.rt_style	= st_retime_style_packed,		\
@@ -324,8 +324,8 @@ static const struct st_pctl_data  stih415_right_data = {
 };
 
 /* STiH416 data */
-unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500,
-			1750, 2000, 2250, 2500, 2750, 3000, 3250 };
+static unsigned int stih416_delays[] = {0, 300, 500, 750, 1000, 1250, 1500,
+				1750, 2000, 2250, 2500, 2750, 3000, 3250 };
 
 static const struct st_pctl_data  stih416_data = {
 	.rt_style	= st_retime_style_dedicated,
@@ -811,7 +811,7 @@ static int st_pmx_get_funcs_count(struct pinctrl_dev *pctldev)
 	return info->nfunctions;
 }
 
-const char *st_pmx_get_fname(struct pinctrl_dev *pctldev,
+static const char *st_pmx_get_fname(struct pinctrl_dev *pctldev,
 	unsigned selector)
 {
 	struct st_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
-- 
1.7.10.4

Re: [PATCH 2/3] pinctrl: st: Staticize local symbols

[Linus Walleij]

On Tue, Aug 6, 2013 at 11:12 AM, Jingoo Han <jg1.han@samsung.com> wrote:

> These local symbols are used only in this file.
> Fix the following sparse warning:
>
> drivers/pinctrl/pinctrl-st.c:291:14: warning: symbol 'stih415_input_delays' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-st.c:292:14: warning: symbol 'stih415_output_delays' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-st.c:327:14: warning: symbol 'stih416_delays' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-st.c:814:12: warning: symbol 'st_pmx_get_fname' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

I already got an identical patch by some other sparse hacker, but thanks
anyway!

Yours,
Linus Walleij