* [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register()
@ 2013-12-01 23:55 Jingoo Han
2013-12-01 23:56 ` [PATCH 2/8] backlight: hp680_bl: " Jingoo Han
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:55 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_backlight_device_register() to make cleanup paths simpler,
and remove unnecessary remove().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/jornada720_bl.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
index 3ccb893..6ce96b4 100644
--- a/drivers/video/backlight/jornada720_bl.c
+++ b/drivers/video/backlight/jornada720_bl.c
@@ -115,9 +115,10 @@ static int jornada_bl_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(struct backlight_properties));
props.type = BACKLIGHT_RAW;
props.max_brightness = BL_MAX_BRIGHT;
- bd = backlight_device_register(S1D_DEVICENAME, &pdev->dev, NULL,
- &jornada_bl_ops, &props);
+ bd = devm_backlight_device_register(&pdev->dev, S1D_DEVICENAME,
+ &pdev->dev, NULL, &jornada_bl_ops,
+ &props);
if (IS_ERR(bd)) {
ret = PTR_ERR(bd);
dev_err(&pdev->dev, "failed to register device, err=%x\n", ret);
@@ -139,18 +140,8 @@ static int jornada_bl_probe(struct platform_device *pdev)
return 0;
}
-static int jornada_bl_remove(struct platform_device *pdev)
-{
- struct backlight_device *bd = platform_get_drvdata(pdev);
-
- backlight_device_unregister(bd);
-
- return 0;
-}
-
static struct platform_driver jornada_bl_driver = {
.probe = jornada_bl_probe,
- .remove = jornada_bl_remove,
.driver = {
.name = "jornada_bl",
},
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/8] backlight: hp680_bl: use devm_backlight_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
@ 2013-12-01 23:56 ` Jingoo Han
2013-12-01 23:56 ` [PATCH 3/8] backlight: omap1: " Jingoo Han
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:56 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_backlight_device_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/hp680_bl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/hp680_bl.c b/drivers/video/backlight/hp680_bl.c
index 00076ec..8ea42b8 100644
--- a/drivers/video/backlight/hp680_bl.c
+++ b/drivers/video/backlight/hp680_bl.c
@@ -110,8 +110,8 @@ static int hp680bl_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(struct backlight_properties));
props.type = BACKLIGHT_RAW;
props.max_brightness = HP680_MAX_INTENSITY;
- bd = backlight_device_register("hp680-bl", &pdev->dev, NULL,
- &hp680bl_ops, &props);
+ bd = devm_backlight_device_register(&pdev->dev, "hp680-bl", &pdev->dev,
+ NULL, &hp680bl_ops, &props);
if (IS_ERR(bd))
return PTR_ERR(bd);
@@ -131,8 +131,6 @@ static int hp680bl_remove(struct platform_device *pdev)
bd->props.power = 0;
hp680bl_send_intensity(bd);
- backlight_device_unregister(bd);
-
return 0;
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/8] backlight: omap1: use devm_backlight_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
2013-12-01 23:56 ` [PATCH 2/8] backlight: hp680_bl: " Jingoo Han
@ 2013-12-01 23:56 ` Jingoo Han
2013-12-01 23:57 ` [PATCH 4/8] backlight: ot200_bl: " Jingoo Han
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:56 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_backlight_device_register() to make cleanup paths simpler,
and remove unnecessary remove().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/omap1_bl.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/video/backlight/omap1_bl.c b/drivers/video/backlight/omap1_bl.c
index ac11a46..a0dcd88 100644
--- a/drivers/video/backlight/omap1_bl.c
+++ b/drivers/video/backlight/omap1_bl.c
@@ -146,8 +146,8 @@ static int omapbl_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(struct backlight_properties));
props.type = BACKLIGHT_RAW;
props.max_brightness = OMAPBL_MAX_INTENSITY;
- dev = backlight_device_register("omap-bl", &pdev->dev, bl, &omapbl_ops,
- &props);
+ dev = devm_backlight_device_register(&pdev->dev, "omap-bl", &pdev->dev,
+ bl, &omapbl_ops, &props);
if (IS_ERR(dev))
return PTR_ERR(dev);
@@ -170,20 +170,10 @@ static int omapbl_probe(struct platform_device *pdev)
return 0;
}
-static int omapbl_remove(struct platform_device *pdev)
-{
- struct backlight_device *dev = platform_get_drvdata(pdev);
-
- backlight_device_unregister(dev);
-
- return 0;
-}
-
static SIMPLE_DEV_PM_OPS(omapbl_pm_ops, omapbl_suspend, omapbl_resume);
static struct platform_driver omapbl_driver = {
.probe = omapbl_probe,
- .remove = omapbl_remove,
.driver = {
.name = "omap-bl",
.pm = &omapbl_pm_ops,
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/8] backlight: ot200_bl: use devm_backlight_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
2013-12-01 23:56 ` [PATCH 2/8] backlight: hp680_bl: " Jingoo Han
2013-12-01 23:56 ` [PATCH 3/8] backlight: omap1: " Jingoo Han
@ 2013-12-01 23:57 ` Jingoo Han
2013-12-01 23:57 ` [PATCH 5/8] backlight: tosa: " Jingoo Han
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:57 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_backlight_device_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/ot200_bl.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/ot200_bl.c b/drivers/video/backlight/ot200_bl.c
index fdbb6ee..f5a5202 100644
--- a/drivers/video/backlight/ot200_bl.c
+++ b/drivers/video/backlight/ot200_bl.c
@@ -118,8 +118,9 @@ static int ot200_backlight_probe(struct platform_device *pdev)
props.brightness = 100;
props.type = BACKLIGHT_RAW;
- bl = backlight_device_register(dev_name(&pdev->dev), &pdev->dev, data,
- &ot200_backlight_ops, &props);
+ bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
+ &pdev->dev, data, &ot200_backlight_ops,
+ &props);
if (IS_ERR(bl)) {
dev_err(&pdev->dev, "failed to register backlight\n");
retval = PTR_ERR(bl);
@@ -137,10 +138,6 @@ error_devm_kzalloc:
static int ot200_backlight_remove(struct platform_device *pdev)
{
- struct backlight_device *bl = platform_get_drvdata(pdev);
-
- backlight_device_unregister(bl);
-
/* on module unload set brightness to 100% */
cs5535_mfgpt_write(pwm_timer, MFGPT_REG_COUNTER, 0);
cs5535_mfgpt_write(pwm_timer, MFGPT_REG_SETUP, MFGPT_SETUP_CNTEN);
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 5/8] backlight: tosa: use devm_backlight_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
` (2 preceding siblings ...)
2013-12-01 23:57 ` [PATCH 4/8] backlight: ot200_bl: " Jingoo Han
@ 2013-12-01 23:57 ` Jingoo Han
2013-12-01 23:57 ` [PATCH 6/8] backlight: jornada720: use devm_lcd_device_register() Jingoo Han
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:57 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_backlight_device_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/tosa_bl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c
index b8db933..3ad6765 100644
--- a/drivers/video/backlight/tosa_bl.c
+++ b/drivers/video/backlight/tosa_bl.c
@@ -105,8 +105,9 @@ static int tosa_bl_probe(struct i2c_client *client,
memset(&props, 0, sizeof(struct backlight_properties));
props.type = BACKLIGHT_RAW;
props.max_brightness = 512 - 1;
- data->bl = backlight_device_register("tosa-bl", &client->dev, data,
- &bl_ops, &props);
+ data->bl = devm_backlight_device_register(&client->dev, "tosa-bl",
+ &client->dev, data, &bl_ops,
+ &props);
if (IS_ERR(data->bl)) {
ret = PTR_ERR(data->bl);
goto err_reg;
@@ -128,9 +129,7 @@ static int tosa_bl_remove(struct i2c_client *client)
{
struct tosa_bl_data *data = i2c_get_clientdata(client);
- backlight_device_unregister(data->bl);
data->bl = NULL;
-
return 0;
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 6/8] backlight: jornada720: use devm_lcd_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
` (3 preceding siblings ...)
2013-12-01 23:57 ` [PATCH 5/8] backlight: tosa: " Jingoo Han
@ 2013-12-01 23:57 ` Jingoo Han
2013-12-01 23:58 ` [PATCH 7/8] backlight: l4f00242t03: " Jingoo Han
2013-12-01 23:58 ` [PATCH 8/8] backlight: tosa: " Jingoo Han
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:57 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_lcd_device_register() to make cleanup paths simpler,
and remove unnecessary remove().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/jornada720_lcd.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
index b061413..da3876c 100644
--- a/drivers/video/backlight/jornada720_lcd.c
+++ b/drivers/video/backlight/jornada720_lcd.c
@@ -100,7 +100,8 @@ static int jornada_lcd_probe(struct platform_device *pdev)
struct lcd_device *lcd_device;
int ret;
- lcd_device = lcd_device_register(S1D_DEVICENAME, &pdev->dev, NULL, &jornada_lcd_props);
+ lcd_device = devm_lcd_device_register(&pdev->dev, S1D_DEVICENAME,
+ &pdev->dev, NULL, &jornada_lcd_props);
if (IS_ERR(lcd_device)) {
ret = PTR_ERR(lcd_device);
@@ -119,18 +120,8 @@ static int jornada_lcd_probe(struct platform_device *pdev)
return 0;
}
-static int jornada_lcd_remove(struct platform_device *pdev)
-{
- struct lcd_device *lcd_device = platform_get_drvdata(pdev);
-
- lcd_device_unregister(lcd_device);
-
- return 0;
-}
-
static struct platform_driver jornada_lcd_driver = {
.probe = jornada_lcd_probe,
- .remove = jornada_lcd_remove,
.driver = {
.name = "jornada_lcd",
},
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 7/8] backlight: l4f00242t03: use devm_lcd_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
` (4 preceding siblings ...)
2013-12-01 23:57 ` [PATCH 6/8] backlight: jornada720: use devm_lcd_device_register() Jingoo Han
@ 2013-12-01 23:58 ` Jingoo Han
2013-12-01 23:58 ` [PATCH 8/8] backlight: tosa: " Jingoo Han
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:58 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_lcd_device_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/l4f00242t03.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index b5fc13b..63e7638 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -223,8 +223,8 @@ static int l4f00242t03_probe(struct spi_device *spi)
return PTR_ERR(priv->core_reg);
}
- priv->ld = lcd_device_register("l4f00242t03",
- &spi->dev, priv, &l4f_ops);
+ priv->ld = devm_lcd_device_register(&spi->dev, "l4f00242t03", &spi->dev,
+ priv, &l4f_ops);
if (IS_ERR(priv->ld))
return PTR_ERR(priv->ld);
@@ -243,8 +243,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
struct l4f00242t03_priv *priv = spi_get_drvdata(spi);
l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
- lcd_device_unregister(priv->ld);
-
return 0;
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 8/8] backlight: tosa: use devm_lcd_device_register()
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
` (5 preceding siblings ...)
2013-12-01 23:58 ` [PATCH 7/8] backlight: l4f00242t03: " Jingoo Han
@ 2013-12-01 23:58 ` Jingoo Han
6 siblings, 0 replies; 8+ messages in thread
From: Jingoo Han @ 2013-12-01 23:58 UTC (permalink / raw)
To: 'Andrew Morton'; +Cc: linux-kernel, 'Jingoo Han'
Use devm_lcd_device_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/tosa_lcd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c
index be5d636..f08d641 100644
--- a/drivers/video/backlight/tosa_lcd.c
+++ b/drivers/video/backlight/tosa_lcd.c
@@ -206,8 +206,8 @@ static int tosa_lcd_probe(struct spi_device *spi)
tosa_lcd_tg_on(data);
- data->lcd = lcd_device_register("tosa-lcd", &spi->dev, data,
- &tosa_lcd_ops);
+ data->lcd = devm_lcd_device_register(&spi->dev, "tosa-lcd", &spi->dev,
+ data, &tosa_lcd_ops);
if (IS_ERR(data->lcd)) {
ret = PTR_ERR(data->lcd);
@@ -226,8 +226,6 @@ static int tosa_lcd_remove(struct spi_device *spi)
{
struct tosa_lcd_data *data = spi_get_drvdata(spi);
- lcd_device_unregister(data->lcd);
-
if (data->i2c)
i2c_unregister_device(data->i2c);
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-12-01 23:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-01 23:55 [PATCH 1/8] backlight: jornada720: use devm_backlight_device_register() Jingoo Han
2013-12-01 23:56 ` [PATCH 2/8] backlight: hp680_bl: " Jingoo Han
2013-12-01 23:56 ` [PATCH 3/8] backlight: omap1: " Jingoo Han
2013-12-01 23:57 ` [PATCH 4/8] backlight: ot200_bl: " Jingoo Han
2013-12-01 23:57 ` [PATCH 5/8] backlight: tosa: " Jingoo Han
2013-12-01 23:57 ` [PATCH 6/8] backlight: jornada720: use devm_lcd_device_register() Jingoo Han
2013-12-01 23:58 ` [PATCH 7/8] backlight: l4f00242t03: " Jingoo Han
2013-12-01 23:58 ` [PATCH 8/8] backlight: tosa: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®