* [PATCH 3/3] pinctrl: sirf: add missing __iomem annotation
@ 2013-08-06 9:14 Jingoo Han
2013-08-07 19:37 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-06 9:14 UTC (permalink / raw)
To: 'Linus Walleij'; +Cc: linux-kernel, Barry Song, Jingoo Han
Added missing __iomem annotation in order to fix the following
sparse warnings:
drivers/pinctrl/sirf/pinctrl-sirf.c:846:14: warning: incorrect type in assignment (different address spaces)
drivers/pinctrl/sirf/pinctrl-sirf.c:846:14: expected void *regs
drivers/pinctrl/sirf/pinctrl-sirf.c:846:14: got void [noderef] <asn:2>*
drivers/pinctrl/sirf/pinctrl-sirf.c:869:33: warning: incorrect type in assignment (different address spaces)
drivers/pinctrl/sirf/pinctrl-sirf.c:869:33: expected void [noderef] <asn:2>*regs
drivers/pinctrl/sirf/pinctrl-sirf.c:869:33: got void *regs
drivers/pinctrl/sirf/pinctrl-sirf.c:909:17: warning: incorrect type in argument 1 (different address spaces)
drivers/pinctrl/sirf/pinctrl-sirf.c:909:17: expected void volatile [noderef] <asn:2>*addr
drivers/pinctrl/sirf/pinctrl-sirf.c:909:17: got void *regs
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pinctrl/sirf/pinctrl-sirf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sirf/pinctrl-sirf.c b/drivers/pinctrl/sirf/pinctrl-sirf.c
index 0792e8d..26f946a 100644
--- a/drivers/pinctrl/sirf/pinctrl-sirf.c
+++ b/drivers/pinctrl/sirf/pinctrl-sirf.c
@@ -833,7 +833,7 @@ static int sirfsoc_gpio_probe(struct device_node *np)
{
int i, err = 0;
struct sirfsoc_gpio_bank *bank;
- void *regs;
+ void __iomem *regs;
struct platform_device *pdev;
bool is_marco = false;
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 3/3] pinctrl: sirf: add missing __iomem annotation
2013-08-06 9:14 [PATCH 3/3] pinctrl: sirf: add missing __iomem annotation Jingoo Han
@ 2013-08-07 19:37 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-08-07 19:37 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, Barry Song
On Tue, Aug 6, 2013 at 11:14 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Added missing __iomem annotation in order to fix the following
> sparse warnings:
>
> drivers/pinctrl/sirf/pinctrl-sirf.c:846:14: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/sirf/pinctrl-sirf.c:846:14: expected void *regs
> drivers/pinctrl/sirf/pinctrl-sirf.c:846:14: got void [noderef] <asn:2>*
> drivers/pinctrl/sirf/pinctrl-sirf.c:869:33: warning: incorrect type in assignment (different address spaces)
> drivers/pinctrl/sirf/pinctrl-sirf.c:869:33: expected void [noderef] <asn:2>*regs
> drivers/pinctrl/sirf/pinctrl-sirf.c:869:33: got void *regs
> drivers/pinctrl/sirf/pinctrl-sirf.c:909:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/pinctrl/sirf/pinctrl-sirf.c:909:17: expected void volatile [noderef] <asn:2>*addr
> drivers/pinctrl/sirf/pinctrl-sirf.c:909:17: got void *regs
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-07 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-06 9:14 [PATCH 3/3] pinctrl: sirf: add missing __iomem annotation Jingoo Han
2013-08-07 19:37 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®