From: "Sean Hefty" <sean.hefty@intel.com>
To: "'Michael S. Tsirkin'" <mst@mellanox.co.il>,
"Zach Brown" <zach.brown@oracle.com>,
"Hal Rosenstock" <halr@voltaire.com>,
"Roland Dreier" <rolandd@cisco.com>
Cc: <openib-general@openib.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Arjan van de Ven" <arjan@infradead.org>,
"Ingo Molnar" <mingo@elte.hu>
Subject: RE: ipoib lockdep warning
Date: Tue, 11 Jul 2006 14:40:32 -0700 [thread overview]
Message-ID: <000401c6a532$a3017f50$e598070a@amr.corp.intel.com> (raw)
In-Reply-To: <20060711211620.GB21546@mellanox.co.il>
>Quoting r. Zach Brown <zach.brown@oracle.com>:
>> BC:
>>
>> query_idr.lock is taken with interrupts enabled and so is implicitly
>> ordered before dev->_xmit_lock which is taken in interrupt context.
>>
>> ipoib_mcast_join_task()
>> ipoib_mcast_join()
>> ib_sa_mcmember_rec_query()
>> send_mad()
>> idr_pre_get(&query_idr)
>> spin_lock(&idp->lock)
>
>Got to check, but if that's true we have a simple deadlock here:
>ib_sa_mcmember_rec_query might get called from interrupt
>context as well, deadlocking on idp->lock?
>
>Sean?
As a side note, I believe that this is the upstream code and does not include
the latest multicast changes.
I'm not sure if anything calls into the sa_query interfaces from interrupt
context, but I doubt it. From my brief look at the initially reported issue, I
can't determine if there's an actual problem without studying the ipoib code
more.
- Sean
next prev parent reply other threads:[~2006-07-11 21:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 20:10 Zach Brown
2006-07-11 21:16 ` Michael S. Tsirkin
2006-07-11 21:40 ` Sean Hefty [this message]
2006-07-11 21:50 ` [openib-general] " Zach Brown
2006-07-11 22:54 ` Roland Dreier
2006-07-11 23:27 ` Zach Brown
2006-07-11 23:43 ` Roland Dreier
2006-07-11 23:53 ` Zach Brown
2006-07-12 0:06 ` Roland Dreier
2006-07-12 9:38 ` Ingo Molnar
2006-07-12 11:09 ` Michael S. Tsirkin
2006-07-12 16:31 ` [openib-general] " Sean Hefty
2006-07-12 18:56 ` Roland Dreier
2006-07-13 15:55 ` [PATCH] IB/core: use correct gfp_mask in sa_query Michael S. Tsirkin
2006-07-12 19:06 ` [openib-general] ipoib lockdep warning Roland Dreier
2006-07-12 20:45 ` [PATCH] Convert idr's internal locking to _irqsave variant Roland Dreier
2006-07-12 21:14 ` Ingo Molnar
2006-07-13 1:30 ` Andrew Morton
2006-07-13 15:42 ` Roland Dreier
2006-07-13 20:54 ` Andrew Morton
2006-07-13 21:03 ` Roland Dreier
2006-07-13 21:05 ` Arjan van de Ven
2006-07-14 0:18 ` Roland Dreier
2006-07-14 6:20 ` Arjan van de Ven
2006-07-13 21:43 ` Andrew Morton
2006-07-14 1:08 ` Roland Dreier
2006-07-14 1:18 ` Andrew Morton
2006-07-14 1:30 ` Andrew Morton
2006-07-17 15:57 ` Roland Dreier
2006-07-12 2:33 ` [openib-general] ipoib lockdep warning Roland Dreier
2006-07-12 6:49 ` Arjan van de Ven
2006-07-12 19:01 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401c6a532$a3017f50$e598070a@amr.corp.intel.com' \
--to=sean.hefty@intel.com \
--cc=arjan@infradead.org \
--cc=halr@voltaire.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@mellanox.co.il \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome