mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mitchell Erblich" <erblichs@earthlink.net>
To: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Cc: <akpm@zip.com.au>, "Ingo Molnar" <mingo@elte.hu>,
	"\"Dmitry Adamushko\"" <dmitry.adamushko@gmail.com>
Subject: minor Suggested cleanup: RT / sched : Have RT tasks use PF_LESS_THROTTLE flag
Date: Tue, 14 Aug 2007 11:45:25 -0700	[thread overview]
Message-ID: <000501c7dea3$48bf98a0$6501a8c0@earthlink.net> (raw)

Group, Ingo Molnar, and Dmitry, et al,

task mm/page-writeback.c : get_dirty_limits()

Shouldn't the PF_LESS_THROTTLE flag be
scheduling class independent?

The below is a suggestion is to use the flag for
RT tasks.

-- to drop the rt_task() call within the function

if (tsk->flags & PF_LESS_THROTTLE || rt_task(tsk)) {

1) becomes
if (tsk->flags & PF_LESS_THROTTLE)

Then 
2) in kernel/sched.c set:
   p->flags |= PF_LESS_THROTTLE before the break;

case SCHED_FIFO:
case SCHED_RR:
              p->sched_class = &rt_sched_class;
              p->flags |= PF_LESS_THROTTLE;
            break;

3) Unset it in case sched class changed; before the break
case SCHED_NORMAL:
case SCHED_BATCH:
case SCHED_IDLE:
           p->sched_class = &fair_sched_class;
           p->flags &= ~PF_LESS_THROTTLE;
           break;

4) set the flag rt_mutex_setprio with braces
if (rt_prio(prio)) {
                 p->sched_class = &rt_sched_class;
                 p->flags |= PF_LESS_THROTTLE;

                 
 }      else


5) Am I missing anything?

Mitchell Erblich


                 reply	other threads:[~2007-08-14 18:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000501c7dea3$48bf98a0$6501a8c0@earthlink.net' \
    --to=erblichs@earthlink.net \
    --cc=akpm@zip.com.au \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®