mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* minor Suggested cleanup: RT / sched : Have RT tasks use PF_LESS_THROTTLE flag
@ 2007-08-14 18:45 Mitchell Erblich
  0 siblings, 0 replies; only message in thread
From: Mitchell Erblich @ 2007-08-14 18:45 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: akpm, Ingo Molnar, "Dmitry Adamushko"

Group, Ingo Molnar, and Dmitry, et al,

task mm/page-writeback.c : get_dirty_limits()

Shouldn't the PF_LESS_THROTTLE flag be
scheduling class independent?

The below is a suggestion is to use the flag for
RT tasks.

-- to drop the rt_task() call within the function

if (tsk->flags & PF_LESS_THROTTLE || rt_task(tsk)) {

1) becomes
if (tsk->flags & PF_LESS_THROTTLE)

Then 
2) in kernel/sched.c set:
   p->flags |= PF_LESS_THROTTLE before the break;

case SCHED_FIFO:
case SCHED_RR:
              p->sched_class = &rt_sched_class;
              p->flags |= PF_LESS_THROTTLE;
            break;

3) Unset it in case sched class changed; before the break
case SCHED_NORMAL:
case SCHED_BATCH:
case SCHED_IDLE:
           p->sched_class = &fair_sched_class;
           p->flags &= ~PF_LESS_THROTTLE;
           break;

4) set the flag rt_mutex_setprio with braces
if (rt_prio(prio)) {
                 p->sched_class = &rt_sched_class;
                 p->flags |= PF_LESS_THROTTLE;

                 
 }      else


5) Am I missing anything?

Mitchell Erblich


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-08-14 18:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-14 18:45 minor Suggested cleanup: RT / sched : Have RT tasks use PF_LESS_THROTTLE flag Mitchell Erblich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®