mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: dan.carpenter@oracle.com, Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kbuild@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>
Subject: Re: [RFC PATCH] kbuild: Add an option to enable -O1 and speed-up compilation time
Date: Mon, 23 May 2022 22:16:05 +0200	[thread overview]
Message-ID: <00061a71-4d7c-0605-80b5-3d909fc3dfaa@wanadoo.fr> (raw)
In-Reply-To: <CAKwvOdneqUvq+Nz_zPmJmuPFfAvWQgnzrw1AJt=WqQF2hThF-A@mail.gmail.com>

Le 23/05/2022 à 20:26, Nick Desaulniers a écrit :
> On Sat, May 21, 2022 at 2:04 AM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>>
>> Add a new compilation option which speeds-up compilation time.
>> This can be useful when using static checker such as smatch or build-bots.
>> In such cases, the speed and quality of the generated code is not
>> important.
>>
>> Using -O0 would be even better, but unfortunately, building fails with
>> this option.
> 
> Which is a tragedy.
> 
> As with the Rust series, I'm not a fan of this (or
> CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE_O3):
> https://lore.kernel.org/lkml/CAKwvOd=7QTUH69+ZbT7e8einvgcosTbDkyohmPaUBv6_y8RfrQ@mail.gmail.com/
> 
> These feel more like attempts to wrap every conceivable command line
> flag in a kconfig option, which makes me think of that meme from
> Jurassic Park: "your scientists were so preoccupied with whether or
> not they could, they didn't stop to think if they should."
> Not a fan.  I'd ask for measurements, but that would be a request for
> a "rock fetching quest" for something I still wouldn't be a fan of.

Hi,

some preliminary tests gave roughly a 5% build time speed-up with -O1.
That is to say that the impact seems quite limited, after all.
This was done on building /drivers/net/ or /drivers/net/ethernet/ only.

I don't have numbers for the impact on memory consumption.

Given the feedbacks on -O1 which is unlikely to be able to build a full 
kernel and your position on yet another option for a very specific use 
case, I won't push the idea further.

I'll keep it in my own tree for (small) build time improvement when 
running smatch.

The idea of turning off a subset of -O2 options would just be some too 
fine tuning. I'll certainly try it for my own use, but it would end to 
an un-understandable list of flags in Makefile.
-O1 (or -O0) was simple. A more complex solution is way too much.


Thanks for your feedbacks.

CJ

> 
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   Makefile     | 5 ++++-
>>   init/Kconfig | 8 ++++++++
>>   2 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 1f8bef92868f..14467386f947 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -817,7 +817,10 @@ KBUILD_CFLAGS      += $(call cc-disable-warning, format-truncation)
>>   KBUILD_CFLAGS  += $(call cc-disable-warning, format-overflow)
>>   KBUILD_CFLAGS  += $(call cc-disable-warning, address-of-packed-member)
>>
>> -ifdef CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE
>> +ifdef CONFIG_CC_OPTIMIZE_FOR_COMPILATION_SPEED
>> +KBUILD_CFLAGS += -O1
>> +KBUILD_RUSTFLAGS_OPT_LEVEL_MAP := 1
>> +else ifdef CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE
>>   KBUILD_CFLAGS += -O2
>>   KBUILD_RUSTFLAGS_OPT_LEVEL_MAP := 2
>>   else ifdef CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE_O3
>> diff --git a/init/Kconfig b/init/Kconfig
>> index a96776a9b080..3177a1830c9a 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -1384,6 +1384,14 @@ choice
>>          prompt "Compiler optimization level"
>>          default CC_OPTIMIZE_FOR_PERFORMANCE
>>
>> +config CC_OPTIMIZE_FOR_COMPILATION_SPEED
>> +       bool "Optimize for compilation speed (-O1)"
>> +       help
>> +         This option can be useful when running a static checker such as smatch
>> +         or a build-bot.
>> +         Compilation time is slighly faster than -O2 and it requires less
> 
> s/slighly/slightly/

Thanks for taking time for a full review, even on something you are not 
fan on. This is really appreciated.

CJ

> 
>> +         memory.
>> +
>>   config CC_OPTIMIZE_FOR_PERFORMANCE
>>          bool "Optimize for performance (-O2)"
>>          help
>> --
>> 2.34.1
>>
> 
> 


  reply	other threads:[~2022-05-23 20:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21  9:04 Christophe JAILLET
2022-05-21 15:38 ` Masahiro Yamada
2022-05-23 12:34   ` Changbin Du
2022-05-23 12:50     ` Arnd Bergmann
2022-05-23 18:26 ` Nick Desaulniers
2022-05-23 20:16   ` Christophe JAILLET [this message]
2022-05-23 20:31     ` Nick Desaulniers
2022-05-24 14:16   ` Miguel Ojeda
2022-05-23 20:25 ` Miguel Ojeda
2022-05-23 20:44   ` Christophe JAILLET
2022-05-24 14:16     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00061a71-4d7c-0605-80b5-3d909fc3dfaa@wanadoo.fr \
    --to=christophe.jaillet@wanadoo.fr \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®