[PATCH 3.8-stable] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440

[PATCH 3.8-stable] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440

[Jonghwan Choi]

3.8-stable review patch.  If anyone has any objections, please let me know.

------------------

From: "Sylwester Nawrocki <s.nawrocki@samsung.com>"

commit b530f742ac27460d41d35b638ad6aad92044a982 upstream.

Due to NR_IRQS being incorrectly defined not all IRQ domains can
be registered for S3C2440. It causes following errors on a s3c2440
SoC based board:

NR_IRQS:89
S3C2440: IRQ Support
irq: clearing pending status 00000002
------------[ cut here ]------------
WARNING: at kernel/irq/irqdomain.c:234 0xc0056ed0()
...
irq: could not create irq-domain
...
s3c2410-wdt s3c2410-wdt: failed to install irq (-22)
s3c2410-wdt: probe of s3c2410-wdt failed with error -22
...
samsung-uart s3c2440-uart.0: cannot get irq 74

Fix this by increasing NR_IRQS to at least (IRQ_S3C2443_AC97 + 1)
if CPU_S3C2440 is selected, so the subintc IRQ domain gets properly
registered.

Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 arch/arm/mach-s3c24xx/include/mach/irqs.h |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/include/mach/irqs.h
b/arch/arm/mach-s3c24xx/include/mach/irqs.h
index b7a9f4d..1e73f5f 100644
--- a/arch/arm/mach-s3c24xx/include/mach/irqs.h
+++ b/arch/arm/mach-s3c24xx/include/mach/irqs.h
@@ -188,10 +188,8 @@
 
 #if defined(CONFIG_CPU_S3C2416)
 #define NR_IRQS (IRQ_S3C2416_I2S1 + 1)
-#elif defined(CONFIG_CPU_S3C2443)
-#define NR_IRQS (IRQ_S3C2443_AC97+1)
 #else
-#define NR_IRQS (IRQ_S3C2440_AC97+1)
+#define NR_IRQS (IRQ_S3C2443_AC97 + 1)
 #endif
 
 /* compatibility define. */
-- 
1.7.9.5

Re: [PATCH 3.8-stable] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440

[Greg KH]

On Tue, Apr 23, 2013 at 11:59:13AM +0900, Jonghwan Choi wrote:
> 3.8-stable review patch.  If anyone has any objections, please let me know.

Why, what are you going to do with this?  :)

I thought you were going to change the wording of your emails, what
happened?

greg k-h

RE: [PATCH 3.8-stable] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440

[Jonghwan Choi]

Oh my god~.

Maybe I was insane
When I send emails, I usually photocopy this part and use it,
but I accidently made a mistake.
I am so so sorry.

Best Regards.

Thanks.

> -----Original Message-----
> From: stable-owner@vger.kernel.org [mailto:stable-owner@vger.kernel.org]
> On Behalf Of Greg KH
> Sent: Tuesday, April 23, 2013 12:09 PM
> To: Jonghwan Choi
> Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; 'Sylwester
> Nawrocki'; 'Kukjin Kim'; 'Tomasz Figa'
> Subject: Re: [PATCH 3.8-stable] ARM: S3C24XX: Correct NR_IRQS definition
> for s3c2440
> 
> On Tue, Apr 23, 2013 at 11:59:13AM +0900, Jonghwan Choi wrote:
> > 3.8-stable review patch.  If anyone has any objections, please let me
> know.
> 
> Why, what are you going to do with this?  :)
> 
> I thought you were going to change the wording of your emails, what
> happened?
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html