From: Jingoo Han <jg1.han@samsung.com>
To: "'Josh Triplett'" <josh@joshtriplett.org>
Cc: "'David Woodhouse'" <dwmw2@infradead.org>,
"'Brian Norris'" <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>,
"'Dinh Nguyen'" <dinguyen@altera.com>
Subject: Re: [PATCH 1/7] mtd: denali: Drop print of build date/time
Date: Thu, 26 Dec 2013 17:24:53 +0900 [thread overview]
Message-ID: <000801cf0213$f40bec50$dc23c4f0$%han@samsung.com> (raw)
In-Reply-To: <21175198efaf34a67e5108c1dae384656012b7a0.1387833347.git.josh@joshtriplett.org>
On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote:
>
> The kernel already has this information, and individual drivers
> shouldn't duplicate that. This also eliminates the use of __DATE__ and
> __TIME__, which make the build non-deterministic.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
(+cc Dinh Nguyen)
It looks good. :-)
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/mtd/nand/denali_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
> index 033f177..ab64416 100644
> --- a/drivers/mtd/nand/denali_pci.c
> +++ b/drivers/mtd/nand/denali_pci.c
> @@ -131,7 +131,6 @@ static struct pci_driver denali_pci_driver = {
>
> static int denali_init_pci(void)
> {
> - pr_info("Spectra MTD driver built on %s @ %s\n", __DATE__, __TIME__);
> return pci_register_driver(&denali_pci_driver);
> }
> module_init(denali_init_pci);
> --
> 1.8.5.2
next prev parent reply other threads:[~2013-12-26 8:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1387833347.git.josh@joshtriplett.org>
2013-12-23 21:54 ` Josh Triplett
2013-12-26 8:24 ` Jingoo Han [this message]
2014-01-09 16:55 ` Brian Norris
2013-12-23 21:55 ` [PATCH 2/7] net: wireless: brcm80211: Drop debug version with " Josh Triplett
2013-12-23 21:55 ` [PATCH 3/7] staging: rtl8188eu: Drop print of " Josh Triplett
2013-12-24 1:15 ` Larry Finger
2013-12-23 21:55 ` [PATCH 4/7] staging: rts5139: Drop print of build time Josh Triplett
2013-12-23 21:55 ` [PATCH 5/7] staging: wlags49_h2: Drop debug macro recording build date/time Josh Triplett
2013-12-23 21:55 ` [PATCH 6/7] x86: math-emu: Drop already-disabled print of build date Josh Triplett
2013-12-23 21:56 ` [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it Josh Triplett
2014-01-03 16:40 ` Michal Marek
2014-01-03 20:29 ` Josh Triplett
2014-01-03 20:55 ` Michal Marek
2014-01-03 21:00 ` Josh Triplett
2014-01-14 20:56 ` Michal Marek
2014-01-14 21:40 ` Josh Triplett
2014-01-14 21:46 ` Greg KH
2014-01-27 22:57 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801cf0213$f40bec50$dc23c4f0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=computersforpeace@gmail.com \
--cc=dinguyen@altera.com \
--cc=dwmw2@infradead.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome