From: Larry Finger <Larry.Finger@lwfinger.net>
To: Josh Triplett <josh@joshtriplett.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] staging: rtl8188eu: Drop print of build date/time
Date: Mon, 23 Dec 2013 19:15:36 -0600 [thread overview]
Message-ID: <52B8E038.2010208@lwfinger.net> (raw)
In-Reply-To: <d50d2e14a689b41986fbfc27dc9312553ed60ebf.1387833347.git.josh@joshtriplett.org>
On 12/23/2013 03:55 PM, Josh Triplett wrote:
> The kernel already has this information, and individual drivers
> shouldn't duplicate that. This also eliminates the use of __DATE__ and
> __TIME__, which make the build non-deterministic.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> index 7d14779..d44f606 100644
> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> @@ -865,7 +865,6 @@ static int __init rtw_drv_entry(void)
> RT_TRACE(_module_hci_intfs_c_, _drv_err_, ("+rtw_drv_entry\n"));
>
> DBG_88E(DRV_NAME " driver version=%s\n", DRIVERVERSION);
> - DBG_88E("build time: %s %s\n", __DATE__, __TIME__);
>
> rtw_suspend_lock_init();
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
>
>
next prev parent reply other threads:[~2013-12-24 1:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1387833347.git.josh@joshtriplett.org>
2013-12-23 21:54 ` [PATCH 1/7] mtd: denali: " Josh Triplett
2013-12-26 8:24 ` Jingoo Han
2014-01-09 16:55 ` Brian Norris
2013-12-23 21:55 ` [PATCH 2/7] net: wireless: brcm80211: Drop debug version with " Josh Triplett
2013-12-23 21:55 ` [PATCH 3/7] staging: rtl8188eu: Drop print of " Josh Triplett
2013-12-24 1:15 ` Larry Finger [this message]
2013-12-23 21:55 ` [PATCH 4/7] staging: rts5139: Drop print of build time Josh Triplett
2013-12-23 21:55 ` [PATCH 5/7] staging: wlags49_h2: Drop debug macro recording build date/time Josh Triplett
2013-12-23 21:55 ` [PATCH 6/7] x86: math-emu: Drop already-disabled print of build date Josh Triplett
2013-12-23 21:56 ` [PATCH 7/7] Makefile: Build with -Werror=date-time if the compiler supports it Josh Triplett
2014-01-03 16:40 ` Michal Marek
2014-01-03 20:29 ` Josh Triplett
2014-01-03 20:55 ` Michal Marek
2014-01-03 21:00 ` Josh Triplett
2014-01-14 20:56 ` Michal Marek
2014-01-14 21:40 ` Josh Triplett
2014-01-14 21:46 ` Greg KH
2014-01-27 22:57 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B8E038.2010208@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome