POSSIBLE BUG: Debugging Not Automatically Activated in Slab.c

POSSIBLE BUG: Debugging Not Automatically Activated in Slab.c

[Joseph D. Wagner]

Before I submit this as an actually bug, I'd like the input of some people
who know a little more about the Slab Allocator and Kernel Debugging.

The Slab Allocator includes this line:

#ifdef CONFIG_DEBUG_SLAB

in slab.c (line 89) to activate debugging.

However, I couldn't find anywhere in the code where CONFIG_DEBUG_SLAB is
linked to CONFIG_DEBUG_KERNEL.  In other words, setting the kernel as a
debug kernel doesn't automatically set the Slab Allocator to debug too.

1) Am I missing something?

2) Is this intentional or by design?

If this is an actually bug, it can be fixed by inserting the following code
in slab.h immediately following the #include statements:

#ifdef CONFIG_DEBUG_KERNEL
#define CONFIG_DEBUG_SLAB
#endif

Joseph Wagner

Re: POSSIBLE BUG: Debugging Not Automatically Activated in Slab.c

[Randy.Dunlap]

On Fri, 6 Dec 2002, Joseph D. Wagner wrote:

| Before I submit this as an actually bug, I'd like the input of some people
| who know a little more about the Slab Allocator and Kernel Debugging.
|
| The Slab Allocator includes this line:
|
| #ifdef CONFIG_DEBUG_SLAB
|
| in slab.c (line 89) to activate debugging.
|
| However, I couldn't find anywhere in the code where CONFIG_DEBUG_SLAB is
| linked to CONFIG_DEBUG_KERNEL.  In other words, setting the kernel as a
| debug kernel doesn't automatically set the Slab Allocator to debug too.

CONFIG_DEBUG_SLAB is a separate option, listed under the
Kernel Hacking config menu (Debug memory allocations).

| 1) Am I missing something?
|
| 2) Is this intentional or by design?

Design.

| If this is an actually bug, it can be fixed by inserting the following code
| in slab.h immediately following the #include statements:
|
| #ifdef CONFIG_DEBUG_KERNEL
| #define CONFIG_DEBUG_SLAB
| #endif

Nope, just enable it.

-- 
~Randy

RE: POSSIBLE BUG: Debugging Not Automatically Activated in Slab.c -- RESOLVED

[Joseph D. Wagner]

Thanks for the non-flame clarification.

Joseph Wagner

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Randy.Dunlap
Sent: Friday, December 06, 2002 11:08 PM
To: Joseph D. Wagner
Cc: 'Linux Kernel Development List'
Subject: Re: POSSIBLE BUG: Debugging Not Automatically Activated in Slab.c

On Fri, 6 Dec 2002, Joseph D. Wagner wrote:

| Before I submit this as an actually bug, I'd like the input of some people
| who know a little more about the Slab Allocator and Kernel Debugging.
|
| The Slab Allocator includes this line:
|
| #ifdef CONFIG_DEBUG_SLAB
|
| in slab.c (line 89) to activate debugging.
|
| However, I couldn't find anywhere in the code where CONFIG_DEBUG_SLAB is
| linked to CONFIG_DEBUG_KERNEL.  In other words, setting the kernel as a
| debug kernel doesn't automatically set the Slab Allocator to debug too.

CONFIG_DEBUG_SLAB is a separate option, listed under the
Kernel Hacking config menu (Debug memory allocations).

| 1) Am I missing something?
|
| 2) Is this intentional or by design?

Design.

| If this is an actually bug, it can be fixed by inserting the following
code
| in slab.h immediately following the #include statements:
|
| #ifdef CONFIG_DEBUG_KERNEL
| #define CONFIG_DEBUG_SLAB
| #endif

Nope, just enable it.

-- 
~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/