From: "Mitchell Erblich" <erblichs@earthlink.net>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: <linux-kernel@vger.kernel.org>
Subject: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :
Date: Wed, 8 Aug 2007 21:24:57 -0700 [thread overview]
Message-ID: <000a01c7da3d$3f946ae0$6501a8c0@earthlink.net> (raw)
1) * Possible wasted stats overhead during dequeue..
sched_rt.c:
Is RT check needed within a RT func?
dequeue_task_rt() calls update_curr_rt()
which checks for priority of RR or FIFO.
WITHIN..
static inline void update_curr_rt(struct rq *rq)
are the two lines..
if (!task_has_rt_policy(curr))
return;
Generally if I am reading this right, then what
RT task is neither FIFO or RR???
Thus, I think those two lines could be removed.
2) nit....
The comment within sched_rt.c
-----> Adding/removing a task to/from a priority array:
Is placed before dequeue_task_rt() where
enqueue_task_rt() is placed above the comment
Thus, the comment should be moved above enqueue_task_rt()
Mitchell Erblich
next reply other threads:[~2007-08-09 4:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 4:24 Mitchell Erblich [this message]
2007-08-09 8:47 ` Dmitry Adamushko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01c7da3d$3f946ae0$6501a8c0@earthlink.net' \
--to=erblichs@earthlink.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®