mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
To: "Mitchell Erblich" <erblichs@earthlink.net>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :
Date: Thu, 9 Aug 2007 10:47:11 +0200	[thread overview]
Message-ID: <b647ffbd0708090147p2b30e6c8g82aeb8880520265b@mail.gmail.com> (raw)
In-Reply-To: <000a01c7da3d$3f946ae0$6501a8c0@earthlink.net>

On 09/08/07, Mitchell Erblich <erblichs@earthlink.net> wrote:
> 1) * Possible wasted stats overhead during dequeue..
> sched_rt.c:
> Is RT check needed within a RT func?
> dequeue_task_rt() calls update_curr_rt()
> which checks for priority of RR or FIFO.
> [ ... ]
> Thus, I think those two lines could be removed.
>
> 2) nit....
> The comment within sched_rt.c
> ----->   Adding/removing a task to/from a priority array:
> Is placed before dequeue_task_rt() where
> enqueue_task_rt() is placed above the comment
>

Both suggestions sound good. I guess, a patch would be welcomed  :-)


>
> Mitchell Erblich
>

-- 
Best regards,
Dmitry Adamushko

      reply	other threads:[~2007-08-09  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09  4:24 Mitchell Erblich
2007-08-09  8:47 ` Dmitry Adamushko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b647ffbd0708090147p2b30e6c8g82aeb8880520265b@mail.gmail.com \
    --to=dmitry.adamushko@gmail.com \
    --cc=erblichs@earthlink.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®