[PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[Inbaraj]

Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.

This fixes make dtbs_check warning as shown below:

arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
bindings/clock/samsung,exynosautov9-clock.yaml

Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
Signed-off-by: Inbaraj <inbaraj.e@samsung.com>
---
 .../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
index 2ab4642679c0..55c4f94a14d1 100644
--- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
@@ -148,7 +148,7 @@ allOf:
           items:
             - const: oscclk
             - const: dout_clkcmu_fsys1_bus
-            - const: dout_clkcmu_fsys1_mmc_card
+            - const: gout_clkcmu_fsys1_mmc_card
             - const: dout_clkcmu_fsys1_usbdrd
 
   - if:
-- 
2.17.1

Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[Krzysztof Kozlowski]

On 04/11/2022 05:00, Inbaraj wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> 
> This fixes make dtbs_check warning as shown below:
> 
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
> From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
> bindings/clock/samsung,exynosautov9-clock.yaml

I don't understand:
1. Why bindings are wrong not DTSI?
2. What is "gout"? "dout" had a meaning as clock divider output.

> 
> Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
> Signed-off-by: Inbaraj <inbaraj.e@samsung.com>
> ---
>  .../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> index 2ab4642679c0..55c4f94a14d1 100644
> --- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
> @@ -148,7 +148,7 @@ allOf:
>            items:
>              - const: oscclk
>              - const: dout_clkcmu_fsys1_bus
> -            - const: dout_clkcmu_fsys1_mmc_card
> +            - const: gout_clkcmu_fsys1_mmc_card
>              - const: dout_clkcmu_fsys1_usbdrd
>  
>    - if:

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[Krzysztof Kozlowski]

On 04/11/2022 05:00, Inbaraj wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> 
> This fixes make dtbs_check warning as shown below:
> 
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
> From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
> bindings/clock/samsung,exynosautov9-clock.yaml
> 
> Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
> Signed-off-by: Inbaraj <inbaraj.e@samsung.com>

One more comment - is Inbaraj your full legal name? Full name must be
used in From and Sob. Your email address has some additional "e", so I
wonder.

Best regards,
Krzysztof

RE: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[CHANHO PARK]

> > Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
> >
> > This fixes make dtbs_check warning as shown below:
> >
> > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> controller@17040000:
> > clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
> > /home/inbaraj/mainline/linux/Documentation/devicetree/
> > bindings/clock/samsung,exynosautov9-clock.yaml
> 
> I don't understand:
> 1. Why bindings are wrong not DTSI?
> 2. What is "gout"? "dout" had a meaning as clock divider output.

"gout" is output of a gate clock, AFAIK.
Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".

> 
> >
> > Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for
> > cmu_fsys0/1")
> > Signed-off-by: Inbaraj <inbaraj.e@samsung.com>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park

Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[Krzysztof Kozlowski]

On 07/11/2022 01:04, CHANHO PARK wrote:
>>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>>>
>>> This fixes make dtbs_check warning as shown below:
>>>
>>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
>> controller@17040000:
>>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From schema:
>>> /home/inbaraj/mainline/linux/Documentation/devicetree/
>>> bindings/clock/samsung,exynosautov9-clock.yaml
>>
>> I don't understand:
>> 1. Why bindings are wrong not DTSI?
>> 2. What is "gout"? "dout" had a meaning as clock divider output.
> 
> "gout" is output of a gate clock, AFAIK.
> Unlike any other clocks, the fsys1 mmc top clock does not have a divider. So, it should be "mout -> gout" instead of "mout -> gout -> dout".

OK, then this should be in commit msg.

My question about full legal name remains, as here in replies I see
"Inbaraj E".

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1 mmc card clock

[Inbaraj E]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 07 November 2022 14:42
> To: chanho61.park@samsung.com; Inbaraj E <inbaraj.e@samsung.com>;
> Sylwester Nawrocki <s.nawrocki@samsung.com>; tomasz.figa@gmail.com;
> Chanwoo Choi <cw00.choi@samsung.com>; ALIM AKHTAR
> <alim.akhtar@samsung.com>; mturquette@baylibre.com;
> sboyd@kernel.org; robh+dt@kernel.org
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; PANKAJ KUMAR DUBEY
> <pankaj.dubey@samsung.com>
> Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to
> CMU_FSYS1 mmc card clock
> 
> On 07/11/2022 01:04, CHANHO PARK wrote:
> >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of
> dout.
> >>>
> >>> This fixes make dtbs_check warning as shown below:
> >>>
> >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-
> >> controller@17040000:
> >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From
> schema:
> >>> /home/inbaraj/mainline/linux/Documentation/devicetree/
> >>> bindings/clock/samsung,exynosautov9-clock.yaml
> >>
> >> I don't understand:
> >> 1. Why bindings are wrong not DTSI?
> >> 2. What is "gout"? "dout" had a meaning as clock divider output.
> >
> > "gout" is output of a gate clock, AFAIK.
> > Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
> So, it should be "mout -> gout" instead of "mout -> gout -> dout".
> 
> OK, then this should be in commit msg.
> 
> My question about full legal name remains, as here in replies I see "Inbaraj
> E".
> 

I have address your review comment, and posted v2. 
Thanks for review.

> Best regards,
> Krzysztof