mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/2] thermal: exynos: Add error handling for temperature code
@ 2012-11-28  0:48 Jonghwan Choi
  0 siblings, 0 replies; only message in thread
From: Jonghwan Choi @ 2012-11-28  0:48 UTC (permalink / raw)
  To: 'Jonghwan Choi', 'open list'
  Cc: 'Amit Daniel Kachhap', 'Zhang Rui',
	'Sachin Kamat'

If temperature code is invalid, it should be handled.

Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 drivers/thermal/exynos_thermal.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/exynos_thermal.c
b/drivers/thermal/exynos_thermal.c
index dc2ad6c..78c5c08 100644
--- a/drivers/thermal/exynos_thermal.c
+++ b/drivers/thermal/exynos_thermal.c
@@ -346,15 +346,19 @@ static int exynos_get_temp(struct thermal_zone_device
*thermal,
                        unsigned long *temp)
 {
        void *data;
+       int tmp;

        if (!th_zone->sensor_conf) {
                pr_info("Temperature sensor not initialised\n");
                return -EINVAL;
        }
        data = th_zone->sensor_conf->private_data;
-       *temp = th_zone->sensor_conf->read_temperature(data);
+       tmp = th_zone->sensor_conf->read_temperature(data);
+       if (tmp < 0)
+               return tmp;
+
        /* convert the temperature into millicelsius */
-       *temp = *temp * MCELSIUS;
+       *temp = tmp * MCELSIUS;
        return 0;
 }

--
1.7.4.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-28  0:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-28  0:48 [PATCH 2/2] thermal: exynos: Add error handling for temperature code Jonghwan Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®