* [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION() macros
@ 2024-06-05 18:18 Jeff Johnson
2024-06-26 4:21 ` Jeff Johnson
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Johnson @ 2024-06-05 18:18 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi
Cc: linux-pm, linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_simpleondemand.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_performance.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_powersave.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_userspace.o
Add all missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/devfreq/governor_performance.c | 1 +
drivers/devfreq/governor_powersave.c | 1 +
drivers/devfreq/governor_simpleondemand.c | 1 +
drivers/devfreq/governor_userspace.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c
index 5dbc1e56ec08..2e4e981446fa 100644
--- a/drivers/devfreq/governor_performance.c
+++ b/drivers/devfreq/governor_performance.c
@@ -58,4 +58,5 @@ static void __exit devfreq_performance_exit(void)
return;
}
module_exit(devfreq_performance_exit);
+MODULE_DESCRIPTION("DEVFREQ Performance governor");
MODULE_LICENSE("GPL");
diff --git a/drivers/devfreq/governor_powersave.c b/drivers/devfreq/governor_powersave.c
index 4746af2435b0..f059e8814804 100644
--- a/drivers/devfreq/governor_powersave.c
+++ b/drivers/devfreq/governor_powersave.c
@@ -58,4 +58,5 @@ static void __exit devfreq_powersave_exit(void)
return;
}
module_exit(devfreq_powersave_exit);
+MODULE_DESCRIPTION("DEVFREQ Powersave governor");
MODULE_LICENSE("GPL");
diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
index d57b82a2b570..c23435736367 100644
--- a/drivers/devfreq/governor_simpleondemand.c
+++ b/drivers/devfreq/governor_simpleondemand.c
@@ -140,4 +140,5 @@ static void __exit devfreq_simple_ondemand_exit(void)
return;
}
module_exit(devfreq_simple_ondemand_exit);
+MODULE_DESCRIPTION("DEVFREQ Simple On-demand governor");
MODULE_LICENSE("GPL");
diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
index d69672ccacc4..d1aa6806b683 100644
--- a/drivers/devfreq/governor_userspace.c
+++ b/drivers/devfreq/governor_userspace.c
@@ -153,4 +153,5 @@ static void __exit devfreq_userspace_exit(void)
return;
}
module_exit(devfreq_userspace_exit);
+MODULE_DESCRIPTION("DEVFREQ Userspace governor");
MODULE_LICENSE("GPL");
---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240605-md-drivers-devfreq-42b19b2594a1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION() macros
2024-06-05 18:18 [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-26 4:21 ` Jeff Johnson
2024-06-26 7:49 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Johnson @ 2024-06-26 4:21 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi
Cc: linux-pm, linux-kernel, kernel-janitors
On 6/5/2024 11:18 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_simpleondemand.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_performance.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_powersave.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_userspace.o
>
> Add all missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/devfreq/governor_performance.c | 1 +
> drivers/devfreq/governor_powersave.c | 1 +
> drivers/devfreq/governor_simpleondemand.c | 1 +
> drivers/devfreq/governor_userspace.c | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c
> index 5dbc1e56ec08..2e4e981446fa 100644
> --- a/drivers/devfreq/governor_performance.c
> +++ b/drivers/devfreq/governor_performance.c
> @@ -58,4 +58,5 @@ static void __exit devfreq_performance_exit(void)
> return;
> }
> module_exit(devfreq_performance_exit);
> +MODULE_DESCRIPTION("DEVFREQ Performance governor");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/devfreq/governor_powersave.c b/drivers/devfreq/governor_powersave.c
> index 4746af2435b0..f059e8814804 100644
> --- a/drivers/devfreq/governor_powersave.c
> +++ b/drivers/devfreq/governor_powersave.c
> @@ -58,4 +58,5 @@ static void __exit devfreq_powersave_exit(void)
> return;
> }
> module_exit(devfreq_powersave_exit);
> +MODULE_DESCRIPTION("DEVFREQ Powersave governor");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
> index d57b82a2b570..c23435736367 100644
> --- a/drivers/devfreq/governor_simpleondemand.c
> +++ b/drivers/devfreq/governor_simpleondemand.c
> @@ -140,4 +140,5 @@ static void __exit devfreq_simple_ondemand_exit(void)
> return;
> }
> module_exit(devfreq_simple_ondemand_exit);
> +MODULE_DESCRIPTION("DEVFREQ Simple On-demand governor");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
> index d69672ccacc4..d1aa6806b683 100644
> --- a/drivers/devfreq/governor_userspace.c
> +++ b/drivers/devfreq/governor_userspace.c
> @@ -153,4 +153,5 @@ static void __exit devfreq_userspace_exit(void)
> return;
> }
> module_exit(devfreq_userspace_exit);
> +MODULE_DESCRIPTION("DEVFREQ Userspace governor");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240605-md-drivers-devfreq-42b19b2594a1
>
Following up to see if anything else is needed from me.
Hoping to see this in linux-next :)
/jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION() macros
2024-06-26 4:21 ` Jeff Johnson
@ 2024-06-26 7:49 ` Chanwoo Choi
2024-07-23 18:31 ` Jeff Johnson
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2024-06-26 7:49 UTC (permalink / raw)
To: 'Jeff Johnson', 'MyungJoo Ham', 'Kyungmin Park'
Cc: linux-pm, linux-kernel, kernel-janitors
> -----Original Message-----
> From: Jeff Johnson <quic_jjohnson@quicinc.com>
> Sent: Wednesday, June 26, 2024 1:21 PM
> To: MyungJoo Ham <myungjoo.ham@samsung.com>; Kyungmin Park
> <kyungmin.park@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>
> Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org
> Subject: Re: [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION()
> macros
>
> On 6/5/2024 11:18 AM, Jeff Johnson wrote:
> > make allmodconfig && make W=1 C=1 reports:
> > WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/devfreq/governor_simpleondemand.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/devfreq/governor_performance.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/devfreq/governor_powersave.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/devfreq/governor_userspace.o
> >
> > Add all missing invocations of the MODULE_DESCRIPTION() macro.
> >
> > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > ---
> > drivers/devfreq/governor_performance.c | 1 +
> > drivers/devfreq/governor_powersave.c | 1 +
> > drivers/devfreq/governor_simpleondemand.c | 1 +
> > drivers/devfreq/governor_userspace.c | 1 +
> > 4 files changed, 4 insertions(+)
> >
> > diff --git a/drivers/devfreq/governor_performance.c
> b/drivers/devfreq/governor_performance.c
> > index 5dbc1e56ec08..2e4e981446fa 100644
> > --- a/drivers/devfreq/governor_performance.c
> > +++ b/drivers/devfreq/governor_performance.c
> > @@ -58,4 +58,5 @@ static void __exit devfreq_performance_exit(void)
> > return;
> > }
> > module_exit(devfreq_performance_exit);
> > +MODULE_DESCRIPTION("DEVFREQ Performance governor");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/devfreq/governor_powersave.c
> b/drivers/devfreq/governor_powersave.c
> > index 4746af2435b0..f059e8814804 100644
> > --- a/drivers/devfreq/governor_powersave.c
> > +++ b/drivers/devfreq/governor_powersave.c
> > @@ -58,4 +58,5 @@ static void __exit devfreq_powersave_exit(void)
> > return;
> > }
> > module_exit(devfreq_powersave_exit);
> > +MODULE_DESCRIPTION("DEVFREQ Powersave governor");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/devfreq/governor_simpleondemand.c
> b/drivers/devfreq/governor_simpleondemand.c
> > index d57b82a2b570..c23435736367 100644
> > --- a/drivers/devfreq/governor_simpleondemand.c
> > +++ b/drivers/devfreq/governor_simpleondemand.c
> > @@ -140,4 +140,5 @@ static void __exit devfreq_simple_ondemand_exit(void)
> > return;
> > }
> > module_exit(devfreq_simple_ondemand_exit);
> > +MODULE_DESCRIPTION("DEVFREQ Simple On-demand governor");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/devfreq/governor_userspace.c
> b/drivers/devfreq/governor_userspace.c
> > index d69672ccacc4..d1aa6806b683 100644
> > --- a/drivers/devfreq/governor_userspace.c
> > +++ b/drivers/devfreq/governor_userspace.c
> > @@ -153,4 +153,5 @@ static void __exit devfreq_userspace_exit(void)
> > return;
> > }
> > module_exit(devfreq_userspace_exit);
> > +MODULE_DESCRIPTION("DEVFREQ Userspace governor");
> > MODULE_LICENSE("GPL");
> >
> > ---
> > base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> > change-id: 20240605-md-drivers-devfreq-42b19b2594a1
> >
>
> Following up to see if anything else is needed from me.
> Hoping to see this in linux-next :)
>
> /jeff
I'm sorry for late reply. I applied it.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION() macros
2024-06-26 7:49 ` Chanwoo Choi
@ 2024-07-23 18:31 ` Jeff Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-07-23 18:31 UTC (permalink / raw)
To: Chanwoo Choi, 'MyungJoo Ham', 'Kyungmin Park'
Cc: linux-pm, linux-kernel, kernel-janitors, Greg KH
On 6/26/2024 12:49 AM, Chanwoo Choi wrote:
>
>
>> -----Original Message-----
>> From: Jeff Johnson <quic_jjohnson@quicinc.com>
>> Sent: Wednesday, June 26, 2024 1:21 PM
>> To: MyungJoo Ham <myungjoo.ham@samsung.com>; Kyungmin Park
>> <kyungmin.park@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>
>> Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
>> janitors@vger.kernel.org
>> Subject: Re: [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION()
>> macros
>>
>> On 6/5/2024 11:18 AM, Jeff Johnson wrote:
>>> make allmodconfig && make W=1 C=1 reports:
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/devfreq/governor_simpleondemand.o
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/devfreq/governor_performance.o
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/devfreq/governor_powersave.o
>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/devfreq/governor_userspace.o
>>>
>>> Add all missing invocations of the MODULE_DESCRIPTION() macro.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>> drivers/devfreq/governor_performance.c | 1 +
>>> drivers/devfreq/governor_powersave.c | 1 +
>>> drivers/devfreq/governor_simpleondemand.c | 1 +
>>> drivers/devfreq/governor_userspace.c | 1 +
>>> 4 files changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/devfreq/governor_performance.c
>> b/drivers/devfreq/governor_performance.c
>>> index 5dbc1e56ec08..2e4e981446fa 100644
>>> --- a/drivers/devfreq/governor_performance.c
>>> +++ b/drivers/devfreq/governor_performance.c
>>> @@ -58,4 +58,5 @@ static void __exit devfreq_performance_exit(void)
>>> return;
>>> }
>>> module_exit(devfreq_performance_exit);
>>> +MODULE_DESCRIPTION("DEVFREQ Performance governor");
>>> MODULE_LICENSE("GPL");
>>> diff --git a/drivers/devfreq/governor_powersave.c
>> b/drivers/devfreq/governor_powersave.c
>>> index 4746af2435b0..f059e8814804 100644
>>> --- a/drivers/devfreq/governor_powersave.c
>>> +++ b/drivers/devfreq/governor_powersave.c
>>> @@ -58,4 +58,5 @@ static void __exit devfreq_powersave_exit(void)
>>> return;
>>> }
>>> module_exit(devfreq_powersave_exit);
>>> +MODULE_DESCRIPTION("DEVFREQ Powersave governor");
>>> MODULE_LICENSE("GPL");
>>> diff --git a/drivers/devfreq/governor_simpleondemand.c
>> b/drivers/devfreq/governor_simpleondemand.c
>>> index d57b82a2b570..c23435736367 100644
>>> --- a/drivers/devfreq/governor_simpleondemand.c
>>> +++ b/drivers/devfreq/governor_simpleondemand.c
>>> @@ -140,4 +140,5 @@ static void __exit devfreq_simple_ondemand_exit(void)
>>> return;
>>> }
>>> module_exit(devfreq_simple_ondemand_exit);
>>> +MODULE_DESCRIPTION("DEVFREQ Simple On-demand governor");
>>> MODULE_LICENSE("GPL");
>>> diff --git a/drivers/devfreq/governor_userspace.c
>> b/drivers/devfreq/governor_userspace.c
>>> index d69672ccacc4..d1aa6806b683 100644
>>> --- a/drivers/devfreq/governor_userspace.c
>>> +++ b/drivers/devfreq/governor_userspace.c
>>> @@ -153,4 +153,5 @@ static void __exit devfreq_userspace_exit(void)
>>> return;
>>> }
>>> module_exit(devfreq_userspace_exit);
>>> +MODULE_DESCRIPTION("DEVFREQ Userspace governor");
>>> MODULE_LICENSE("GPL");
>>>
>>> ---
>>> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
>>> change-id: 20240605-md-drivers-devfreq-42b19b2594a1
>>>
>>
>> Following up to see if anything else is needed from me.
>> Hoping to see this in linux-next :)
>>
>> /jeff
>
> I'm sorry for late reply. I applied it.
>
> Thanks,
> Chanwoo Choi
>
Hi,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.
Thanks!
/jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-23 18:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-05 18:18 [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-26 4:21 ` Jeff Johnson
2024-06-26 7:49 ` Chanwoo Choi
2024-07-23 18:31 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®