mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/3] pwm: samsung: add missing device pointer to struct pwm_chip
@ 2012-08-03  6:45 Jingoo Han
  2012-08-09  5:44 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2012-08-03  6:45 UTC (permalink / raw)
  To: 'Thierry Reding'
  Cc: linux-kernel, linux-samsung-soc, 'Jingoo Han'

This patch adds missing device pointer to struct pwm_chip. If the
device pointer is NULL, pwmchip_add() will return error.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on SMDKV310 board
 drivers/pwm/pwm-samsung.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index d103865..e5187c0 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -225,6 +225,7 @@ static int s3c_pwm_probe(struct platform_device *pdev)
 
 	/* calculate base of control bits in TCON */
 	s3c->tcon_base = id == 0 ? 0 : (id * 4) + 4;
+	s3c->chip.dev = &pdev->dev;
 	s3c->chip.ops = &s3c_pwm_ops;
 	s3c->chip.base = -1;
 	s3c->chip.npwm = 1;
-- 
1.7.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 1/3] pwm: samsung: add missing device pointer to struct pwm_chip
  2012-08-03  6:45 [PATCH v2 1/3] pwm: samsung: add missing device pointer to struct pwm_chip Jingoo Han
@ 2012-08-09  5:44 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2012-08-09  5:44 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-kernel, linux-samsung-soc

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

On Fri, Aug 03, 2012 at 03:45:56PM +0900, Jingoo Han wrote:
> This patch adds missing device pointer to struct pwm_chip. If the
> device pointer is NULL, pwmchip_add() will return error.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Thanks, applied to for-next and master.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-09  5:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-03  6:45 [PATCH v2 1/3] pwm: samsung: add missing device pointer to struct pwm_chip Jingoo Han
2012-08-09  5:44 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®