[PATCH] correct uart_B and uart_C clock references for meson8b

[PATCH] correct uart_B and uart_C clock references for meson8b

[hfdevel]

commit b3b6a88d2347d2ec9075603920e616836cb46750
Author: Hans-Frieder Vogt <hfdevel@gmx.net>
Date:   Thu Apr 6 10:21:49 2023 +0200

    [PATCH] correct uart_B and uart_C clock references for meson8b

with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks.
This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts.

Signed-off-by: Hans-Frieder Vogt <hfdevel@gmx.net>
---
 meson8b.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index d5a3fe21e8e7..25f7c985f9ea 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -740,13 +740,13 @@ &uart_A {

 &uart_B {
 	compatible = "amlogic,meson8b-uart";
-	clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
+	clocks = <&xtal>, <&clkc CLKID_UART1>, <&clkc CLKID_CLK81>;
 	clock-names = "xtal", "pclk", "baud";
 };

 &uart_C {
 	compatible = "amlogic,meson8b-uart";
-	clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
+	clocks = <&xtal>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>;
 	clock-names = "xtal", "pclk", "baud";
 };

Re: [PATCH] correct uart_B and uart_C clock references for meson8b

[neil.armstrong]

Hi,

On 06/04/2023 11:33, hfdevel@gmx.net wrote:
> commit b3b6a88d2347d2ec9075603920e616836cb46750
> Author: Hans-Frieder Vogt <hfdevel@gmx.net>
> Date:   Thu Apr 6 10:21:49 2023 +0200
> 
>      [PATCH] correct uart_B and uart_C clock references for meson8b

The subject is wrong, should be: "ARM: dts: meson8b: " and you should also CC the linux-amlogic & linux-arm-kernel MLs likes get_maintainers indicates.

Neil

> 
> with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks.
> This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts.
> 
> Signed-off-by: Hans-Frieder Vogt <hfdevel@gmx.net>
> ---
>   meson8b.dtsi |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d5a3fe21e8e7..25f7c985f9ea 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -740,13 +740,13 @@ &uart_A {
> 
>   &uart_B {
>   	compatible = "amlogic,meson8b-uart";
> -	clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
> +	clocks = <&xtal>, <&clkc CLKID_UART1>, <&clkc CLKID_CLK81>;
>   	clock-names = "xtal", "pclk", "baud";
>   };
> 
>   &uart_C {
>   	compatible = "amlogic,meson8b-uart";
> -	clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
> +	clocks = <&xtal>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>;
>   	clock-names = "xtal", "pclk", "baud";
>   };
> 

Re: [PATCH] correct uart_B and uart_C clock references for meson8b

[Martin Blumenstingl]

Hello,

excellent catch - thanks for finding and fixing this!

On Thu, Apr 6, 2023 at 11:33 AM <hfdevel@gmx.net> wrote:
>
> commit b3b6a88d2347d2ec9075603920e616836cb46750
> Author: Hans-Frieder Vogt <hfdevel@gmx.net>
> Date:   Thu Apr 6 10:21:49 2023 +0200
>
>     [PATCH] correct uart_B and uart_C clock references for meson8b
>
> with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks.
> This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts.

When you're re-sending this with fixed subject line then please also
add the following line above your Signed-off by:
Fixes: 3375aa77135f ("ARM: dts: meson8b: Fix the UART device-tree
schema validation")


Best regards,
Martin