* [PATCH 11/42] rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()
@ 2013-05-03 6:28 Jingoo Han
2013-05-03 8:20 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-03 6:28 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo',
rtc-linux, Jingoo Han, Linus Walleij
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/rtc/rtc-coh901331.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c
index 93c0658..9ad5891 100644
--- a/drivers/rtc/rtc-coh901331.c
+++ b/drivers/rtc/rtc-coh901331.c
@@ -154,10 +154,8 @@ static int __exit coh901331_remove(struct platform_device *pdev)
{
struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
- if (rtap) {
+ if (rtap)
clk_unprepare(rtap->clk);
- platform_set_drvdata(pdev, NULL);
- }
return 0;
}
@@ -220,7 +218,6 @@ static int __init coh901331_probe(struct platform_device *pdev)
return 0;
out_no_rtc:
- platform_set_drvdata(pdev, NULL);
clk_unprepare(rtap->clk);
return ret;
}
--
1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 11/42] rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()
2013-05-03 6:28 [PATCH 11/42] rtc: rtc-coh901331: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-03 8:20 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-05-03 8:20 UTC (permalink / raw)
To: Jingoo Han; +Cc: Andrew Morton, linux-kernel, Alessandro Zummo, rtc-linux
On Fri, May 3, 2013 at 8:28 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-03 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-03 6:28 [PATCH 11/42] rtc: rtc-coh901331: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-03 8:20 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®