From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH V2 02/11] rtc: max77686: use dev_info() instead of printk()
Date: Fri, 15 Feb 2013 15:43:15 +0900 [thread overview]
Message-ID: <001f01ce0b47$bbac2e10$33048a30$%han@samsung.com> (raw)
In-Reply-To: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com>
Fixed the checkpatch warning as below:
WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
No changes since v1:
drivers/rtc/rtc-max77686.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 2da0855..abe27c0 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -507,7 +507,7 @@ static int max77686_rtc_probe(struct platform_device *pdev)
struct max77686_rtc_info *info;
int ret, virq;
- printk(KERN_INFO "%s\n", __func__);
+ dev_info(&pdev->dev, "%s\n", __func__);
info = kzalloc(sizeof(struct max77686_rtc_info), GFP_KERNEL);
if (!info)
@@ -546,7 +546,7 @@ static int max77686_rtc_probe(struct platform_device *pdev)
&max77686_rtc_ops, THIS_MODULE);
if (IS_ERR(info->rtc_dev)) {
- printk(KERN_INFO "%s: fail\n", __func__);
+ dev_info(&pdev->dev, "%s: fail\n", __func__);
ret = PTR_ERR(info->rtc_dev);
dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
--
1.7.2.5
next prev parent reply other threads:[~2013-02-15 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 6:42 [PATCH V2 01/11] rtc: use dev_warn()/dev_dbg()/pr_err() " Jingoo Han
2013-02-15 6:43 ` Jingoo Han [this message]
2013-02-15 6:44 ` [PATCH V2 03/11] rtc: rtc-efi: use dev_err()/dev_warn()/pr_err() " Jingoo Han
2013-02-15 6:44 ` [PATCH V2 04/11] rtc: rtc-ds2404: use dev_err() " Jingoo Han
2013-02-15 6:45 ` [PATCH V2 05/11] rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug() Jingoo Han
2013-02-15 6:46 ` [PATCH V2 06/11] rtc: rtc-at91rm9200: use dev_dbg()/dev_err() " Jingoo Han
2013-02-15 6:46 ` [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk() Jingoo Han
2013-02-15 6:49 ` Joe Perches
2013-02-15 6:52 ` Jingoo Han
2013-02-15 6:47 ` [PATCH V2 08/11] rtc: rtc-vr41xx: use dev_info() " Jingoo Han
2013-02-15 6:47 ` [PATCH V2 09/11] rtc: rtc-sun4v: use pr_warn() " Jingoo Han
2013-02-15 6:48 ` [PATCH V2 10/11] rtc: rtc-pcf8583: use dev_warn() " Jingoo Han
2013-02-15 6:48 ` [PATCH V2 11/11] rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug() Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001f01ce0b47$bbac2e10$33048a30$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®