From: Joe Perches <joe@perches.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk()
Date: Thu, 14 Feb 2013 22:49:38 -0800 [thread overview]
Message-ID: <1360910978.2089.3.camel@joe-AO722> (raw)
In-Reply-To: <002501ce0b48$36cf28e0$a46d7aa0$%han@samsung.com>
On Fri, 2013-02-15 at 15:46 +0900, Jingoo Han wrote:
> Fixed the checkpatch warning as below:
[]
> diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c
[]
> @@ -39,6 +39,8 @@
> * 1.13 Nobuhiro Iwamatsu: Updata driver.
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #include <linux/module.h>
> #include <linux/err.h>
> #include <linux/rtc.h>
> @@ -352,8 +354,7 @@ static void rs5c313_check_xstp_bit(void)
> tm.tm_year = 2000 - 1900;
>
> rs5c313_rtc_set_time(NULL, &tm);
> - printk(KERN_ERR "RICHO RS5C313: invalid value, resetting to "
> - "1 Jan 2000\n");
> + pr_err("RICHO RS5C313: invalid value, resetting to 1 Jan 2000\n");
You could remove the "RICH0 RS5C313: "prefix,
pr_fmt adds it (more or less).
next prev parent reply other threads:[~2013-02-15 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 6:42 [PATCH V2 01/11] rtc: use dev_warn()/dev_dbg()/pr_err() " Jingoo Han
2013-02-15 6:43 ` [PATCH V2 02/11] rtc: max77686: use dev_info() " Jingoo Han
2013-02-15 6:44 ` [PATCH V2 03/11] rtc: rtc-efi: use dev_err()/dev_warn()/pr_err() " Jingoo Han
2013-02-15 6:44 ` [PATCH V2 04/11] rtc: rtc-ds2404: use dev_err() " Jingoo Han
2013-02-15 6:45 ` [PATCH V2 05/11] rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug() Jingoo Han
2013-02-15 6:46 ` [PATCH V2 06/11] rtc: rtc-at91rm9200: use dev_dbg()/dev_err() " Jingoo Han
2013-02-15 6:46 ` [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk() Jingoo Han
2013-02-15 6:49 ` Joe Perches [this message]
2013-02-15 6:52 ` Jingoo Han
2013-02-15 6:47 ` [PATCH V2 08/11] rtc: rtc-vr41xx: use dev_info() " Jingoo Han
2013-02-15 6:47 ` [PATCH V2 09/11] rtc: rtc-sun4v: use pr_warn() " Jingoo Han
2013-02-15 6:48 ` [PATCH V2 10/11] rtc: rtc-pcf8583: use dev_warn() " Jingoo Han
2013-02-15 6:48 ` [PATCH V2 11/11] rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug() Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360910978.2089.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®