* [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:42 Jingoo Han
2013-05-06 8:48 ` Shawn Guo
2013-05-14 11:57 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-06 3:42 UTC (permalink / raw)
To: 'Linus Walleij'
Cc: linux-kernel, Jingoo Han, 'Fabio Estevam', 'Shawn Guo'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pinctrl/pinctrl-mxs.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
index b45c4eb..f5d5643 100644
--- a/drivers/pinctrl/pinctrl-mxs.c
+++ b/drivers/pinctrl/pinctrl-mxs.c
@@ -515,7 +515,6 @@ int mxs_pinctrl_probe(struct platform_device *pdev,
return 0;
err:
- platform_set_drvdata(pdev, NULL);
iounmap(d->base);
return ret;
}
@@ -525,7 +524,6 @@ int mxs_pinctrl_remove(struct platform_device *pdev)
{
struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
pinctrl_unregister(d->pctl);
iounmap(d->base);
--
1.7.2.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()
2013-05-06 3:42 [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 8:48 ` Shawn Guo
2013-05-14 11:57 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2013-05-06 8:48 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Linus Walleij', linux-kernel, 'Fabio Estevam'
On Mon, May 06, 2013 at 12:42:13PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/pinctrl/pinctrl-mxs.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
> index b45c4eb..f5d5643 100644
> --- a/drivers/pinctrl/pinctrl-mxs.c
> +++ b/drivers/pinctrl/pinctrl-mxs.c
> @@ -515,7 +515,6 @@ int mxs_pinctrl_probe(struct platform_device *pdev,
> return 0;
>
> err:
> - platform_set_drvdata(pdev, NULL);
> iounmap(d->base);
> return ret;
> }
> @@ -525,7 +524,6 @@ int mxs_pinctrl_remove(struct platform_device *pdev)
> {
> struct mxs_pinctrl_data *d = platform_get_drvdata(pdev);
>
> - platform_set_drvdata(pdev, NULL);
> pinctrl_unregister(d->pctl);
> iounmap(d->base);
>
> --
> 1.7.2.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata()
2013-05-06 3:42 [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 8:48 ` Shawn Guo
@ 2013-05-14 11:57 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-05-14 11:57 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, Fabio Estevam, Shawn Guo
On Mon, May 6, 2013 at 5:42 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with Shawn's ACK.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-14 11:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-06 3:42 [PATCH 2/4] pinctrl: mxs: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 8:48 ` Shawn Guo
2013-05-14 11:57 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®