* [PATCH 1/2] hwrng: omap - remove unnecessary OOM messages
@ 2014-04-29 8:15 Jingoo Han
2014-04-29 8:16 ` [PATCH 2/2] hwrng: timeriomem " Jingoo Han
2014-05-08 14:01 ` [PATCH 1/2] hwrng: omap " Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2014-04-29 8:15 UTC (permalink / raw)
To: 'Herbert Xu'
Cc: linux-kernel, 'Jingoo Han', 'Michael Buesch',
'Lokesh Vutla'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/char/hw_random/omap-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index 9b89ff4..f66ea25 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -369,10 +369,8 @@ static int omap_rng_probe(struct platform_device *pdev)
int ret;
priv = devm_kzalloc(dev, sizeof(struct omap_rng_dev), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "could not allocate memory\n");
+ if (!priv)
return -ENOMEM;
- };
omap_rng_ops.priv = (unsigned long)priv;
platform_set_drvdata(pdev, priv);
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] hwrng: timeriomem - remove unnecessary OOM messages
2014-04-29 8:15 [PATCH 1/2] hwrng: omap - remove unnecessary OOM messages Jingoo Han
@ 2014-04-29 8:16 ` Jingoo Han
2014-05-08 14:01 ` [PATCH 1/2] hwrng: omap " Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2014-04-29 8:16 UTC (permalink / raw)
To: 'Herbert Xu'
Cc: linux-kernel, 'Jingoo Han', 'Alexander Clouter'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/char/hw_random/timeriomem-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
index 439ff8b..b6ab9ac 100644
--- a/drivers/char/hw_random/timeriomem-rng.c
+++ b/drivers/char/hw_random/timeriomem-rng.c
@@ -120,10 +120,8 @@ static int timeriomem_rng_probe(struct platform_device *pdev)
/* Allocate memory for the device structure (and zero it) */
priv = devm_kzalloc(&pdev->dev,
sizeof(struct timeriomem_rng_private_data), GFP_KERNEL);
- if (!priv) {
- dev_err(&pdev->dev, "failed to allocate device structure.\n");
+ if (!priv)
return -ENOMEM;
- }
platform_set_drvdata(pdev, priv);
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] hwrng: omap - remove unnecessary OOM messages
2014-04-29 8:15 [PATCH 1/2] hwrng: omap - remove unnecessary OOM messages Jingoo Han
2014-04-29 8:16 ` [PATCH 2/2] hwrng: timeriomem " Jingoo Han
@ 2014-05-08 14:01 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2014-05-08 14:01 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Michael Buesch', 'Lokesh Vutla'
On Tue, Apr 29, 2014 at 05:15:36PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Both patches applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-08 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-29 8:15 [PATCH 1/2] hwrng: omap - remove unnecessary OOM messages Jingoo Han
2014-04-29 8:16 ` [PATCH 2/2] hwrng: timeriomem " Jingoo Han
2014-05-08 14:01 ` [PATCH 1/2] hwrng: omap " Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®