* [PATCH 4/4] pinctrl: u300: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:44 Jingoo Han
2013-05-14 11:59 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-06 3:44 UTC (permalink / raw)
To: 'Linus Walleij'; +Cc: linux-kernel, Jingoo Han
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pinctrl/pinctrl-u300.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-u300.c b/drivers/pinctrl/pinctrl-u300.c
index 6a3a750..195191a 100644
--- a/drivers/pinctrl/pinctrl-u300.c
+++ b/drivers/pinctrl/pinctrl-u300.c
@@ -1100,7 +1100,6 @@ static int u300_pmx_remove(struct platform_device *pdev)
struct u300_pmx *upmx = platform_get_drvdata(pdev);
pinctrl_unregister(upmx->pctl);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] pinctrl: u300: remove unnecessary platform_set_drvdata()
2013-05-06 3:44 [PATCH 4/4] pinctrl: u300: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-14 11:59 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-05-14 11:59 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel
On Mon, May 6, 2013 at 5:44 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-14 11:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-06 3:44 [PATCH 4/4] pinctrl: u300: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-14 11:59 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®