* [PATCH] w1: mxc_w1: remove unnecessary platform_set_drvdata()
@ 2013-08-22 2:20 Jingoo Han
2013-08-23 2:44 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-22 2:20 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Evgeniy Polyakov', 'Martin Fuzzey',
'Shawn Guo', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/w1/masters/mxc_w1.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c
index 47e12cf..15c7251 100644
--- a/drivers/w1/masters/mxc_w1.c
+++ b/drivers/w1/masters/mxc_w1.c
@@ -152,8 +152,6 @@ static int mxc_w1_remove(struct platform_device *pdev)
clk_disable_unprepare(mdev->clk);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] w1: mxc_w1: remove unnecessary platform_set_drvdata()
2013-08-22 2:20 [PATCH] w1: mxc_w1: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-23 2:44 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-08-23 2:44 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Evgeniy Polyakov',
'Martin Fuzzey'
On Thu, Aug 22, 2013 at 11:20:58AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/w1/masters/mxc_w1.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c
> index 47e12cf..15c7251 100644
> --- a/drivers/w1/masters/mxc_w1.c
> +++ b/drivers/w1/masters/mxc_w1.c
> @@ -152,8 +152,6 @@ static int mxc_w1_remove(struct platform_device *pdev)
>
> clk_disable_unprepare(mdev->clk);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-23 2:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-22 2:20 [PATCH] w1: mxc_w1: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-23 2:44 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®