* [PATCH] mfd: lpc_ich: Staticize struct 'lpc_chipset_info'
@ 2013-08-01 1:59 Jingoo Han
2013-08-01 8:52 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-01 1:59 UTC (permalink / raw)
To: 'Samuel Ortiz', 'Lee Jones'
Cc: linux-kernel, 'Peter Tyser', 'Jingoo Han'
'lpc_chipset_info' is used only in this file.
Fix the following sparse warning:
drivers/mfd/lpc_ich.c:216:21: warning: symbol 'lpc_chipset_info' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/lpc_ich.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 2403332..9483bc8 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -213,7 +213,7 @@ enum lpc_chipsets {
LPC_COLETO, /* Coleto Creek */
};
-struct lpc_ich_info lpc_chipset_info[] = {
+static struct lpc_ich_info lpc_chipset_info[] = {
[LPC_ICH] = {
.name = "ICH",
.iTCO_version = 1,
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: lpc_ich: Staticize struct 'lpc_chipset_info'
2013-08-01 1:59 [PATCH] mfd: lpc_ich: Staticize struct 'lpc_chipset_info' Jingoo Han
@ 2013-08-01 8:52 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-08-01 8:52 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Samuel Ortiz', linux-kernel, 'Peter Tyser'
On Thu, 01 Aug 2013, Jingoo Han wrote:
> 'lpc_chipset_info' is used only in this file.
>
> Fix the following sparse warning:
>
> drivers/mfd/lpc_ich.c:216:21: warning: symbol 'lpc_chipset_info' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/lpc_ich.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index 2403332..9483bc8 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -213,7 +213,7 @@ enum lpc_chipsets {
> LPC_COLETO, /* Coleto Creek */
> };
>
> -struct lpc_ich_info lpc_chipset_info[] = {
> +static struct lpc_ich_info lpc_chipset_info[] = {
> [LPC_ICH] = {
> .name = "ICH",
> .iTCO_version = 1,
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-01 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-01 1:59 [PATCH] mfd: lpc_ich: Staticize struct 'lpc_chipset_info' Jingoo Han
2013-08-01 8:52 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome