* [PATCH] net: korina: remove deprecated IRQF_DISABLED
@ 2013-09-07 5:20 Michael Opdenacker
2013-09-11 1:00 ` Jingoo Han
2013-09-11 20:14 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michael Opdenacker @ 2013-09-07 5:20 UTC (permalink / raw)
To: davem
Cc: emilio, mugunthanvnm, jg1.han, hsweeten, netdev, linux-kernel,
Michael Opdenacker
This patch proposes to remove the IRQF_DISABLED flag from
drivers/net/ethernet/korina.c
It's a NOOP since 2.6.35 and it will be removed one day.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/net/ethernet/korina.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index 270e65f..a36fa80 100644
--- a/drivers/net/ethernet/korina.c
+++ b/drivers/net/ethernet/korina.c
@@ -996,14 +996,14 @@ static int korina_open(struct net_device *dev)
* that handles the Done Finished
* Ovr and Und Events */
ret = request_irq(lp->rx_irq, korina_rx_dma_interrupt,
- IRQF_DISABLED, "Korina ethernet Rx", dev);
+ 0, "Korina ethernet Rx", dev);
if (ret < 0) {
printk(KERN_ERR "%s: unable to get Rx DMA IRQ %d\n",
dev->name, lp->rx_irq);
goto err_release;
}
ret = request_irq(lp->tx_irq, korina_tx_dma_interrupt,
- IRQF_DISABLED, "Korina ethernet Tx", dev);
+ 0, "Korina ethernet Tx", dev);
if (ret < 0) {
printk(KERN_ERR "%s: unable to get Tx DMA IRQ %d\n",
dev->name, lp->tx_irq);
@@ -1012,7 +1012,7 @@ static int korina_open(struct net_device *dev)
/* Install handler for overrun error. */
ret = request_irq(lp->ovr_irq, korina_ovr_interrupt,
- IRQF_DISABLED, "Ethernet Overflow", dev);
+ 0, "Ethernet Overflow", dev);
if (ret < 0) {
printk(KERN_ERR "%s: unable to get OVR IRQ %d\n",
dev->name, lp->ovr_irq);
@@ -1021,7 +1021,7 @@ static int korina_open(struct net_device *dev)
/* Install handler for underflow error. */
ret = request_irq(lp->und_irq, korina_und_interrupt,
- IRQF_DISABLED, "Ethernet Underflow", dev);
+ 0, "Ethernet Underflow", dev);
if (ret < 0) {
printk(KERN_ERR "%s: unable to get UND IRQ %d\n",
dev->name, lp->und_irq);
--
1.8.1.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: korina: remove deprecated IRQF_DISABLED
2013-09-07 5:20 [PATCH] net: korina: remove deprecated IRQF_DISABLED Michael Opdenacker
@ 2013-09-11 1:00 ` Jingoo Han
2013-09-11 20:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2013-09-11 1:00 UTC (permalink / raw)
To: 'Michael Opdenacker'
Cc: davem, emilio, mugunthanvnm, hsweeten, netdev, linux-kernel
On Saturday, September 07, 2013 2:21 PM, Michael Opdenacker wrote:
>
> This patch proposes to remove the IRQF_DISABLED flag from
> drivers/net/ethernet/korina.c
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/net/ethernet/korina.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: korina: remove deprecated IRQF_DISABLED
2013-09-07 5:20 [PATCH] net: korina: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-09-11 1:00 ` Jingoo Han
@ 2013-09-11 20:14 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-09-11 20:14 UTC (permalink / raw)
To: michael.opdenacker
Cc: emilio, mugunthanvnm, jg1.han, hsweeten, netdev, linux-kernel
From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Date: Sat, 7 Sep 2013 07:20:57 +0200
> This patch proposes to remove the IRQF_DISABLED flag from
> drivers/net/ethernet/korina.c
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-11 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-07 5:20 [PATCH] net: korina: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-09-11 1:00 ` Jingoo Han
2013-09-11 20:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®