* [PATCH 1/4] misc: tifm: remove unnecessary pci_set_drvdata()
@ 2013-09-23 1:35 Jingoo Han
2013-09-23 1:36 ` [PATCH 2/4] misc: ibmasm: " Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jingoo Han @ 2013-09-23 1:35 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Arnd Bergmann', linux-kernel, 'Jingoo Han',
'Alex Dubov'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/misc/tifm_7xx1.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/misc/tifm_7xx1.c b/drivers/misc/tifm_7xx1.c
index f8d66543..ae282a1 100644
--- a/drivers/misc/tifm_7xx1.c
+++ b/drivers/misc/tifm_7xx1.c
@@ -378,7 +378,6 @@ err_out_irq:
err_out_unmap:
iounmap(fm->addr);
err_out_free:
- pci_set_drvdata(dev, NULL);
tifm_free_adapter(fm);
err_out_int:
pci_intx(dev, 0);
@@ -405,8 +404,6 @@ static void tifm_7xx1_remove(struct pci_dev *dev)
for (cnt = 0; cnt < fm->num_sockets; cnt++)
tifm_7xx1_sock_power_off(tifm_7xx1_sock_addr(fm->addr, cnt));
- pci_set_drvdata(dev, NULL);
-
iounmap(fm->addr);
pci_intx(dev, 0);
pci_release_regions(dev);
--
1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/4] misc: ibmasm: remove unnecessary pci_set_drvdata()
2013-09-23 1:35 [PATCH 1/4] misc: tifm: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-09-23 1:36 ` Jingoo Han
2013-09-23 1:37 ` [PATCH 3/4] misc: mei: " Jingoo Han
2013-09-23 1:38 ` [PATCH 4/4] misc: pti: " Jingoo Han
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-09-23 1:36 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Arnd Bergmann', linux-kernel, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/misc/ibmasm/module.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/ibmasm/module.c b/drivers/misc/ibmasm/module.c
index 0346d87..c224039 100644
--- a/drivers/misc/ibmasm/module.c
+++ b/drivers/misc/ibmasm/module.c
@@ -153,7 +153,6 @@ error_ioremap:
error_heartbeat:
ibmasm_event_buffer_exit(sp);
error_eventbuffer:
- pci_set_drvdata(pdev, NULL);
kfree(sp);
error_kmalloc:
pci_release_regions(pdev);
@@ -182,7 +181,6 @@ static void ibmasm_remove_one(struct pci_dev *pdev)
ibmasm_free_remote_input_dev(sp);
iounmap(sp->base_address);
ibmasm_event_buffer_exit(sp);
- pci_set_drvdata(pdev, NULL);
kfree(sp);
pci_release_regions(pdev);
pci_disable_device(pdev);
--
1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 3/4] misc: mei: remove unnecessary pci_set_drvdata()
2013-09-23 1:35 [PATCH 1/4] misc: tifm: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-23 1:36 ` [PATCH 2/4] misc: ibmasm: " Jingoo Han
@ 2013-09-23 1:37 ` Jingoo Han
2013-09-23 1:38 ` [PATCH 4/4] misc: pti: " Jingoo Han
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-09-23 1:37 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Arnd Bergmann', linux-kernel, 'Jingoo Han',
'Tomas Winkler'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/misc/mei/pci-me.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index 1b3844e..1b8a4c6 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -239,7 +239,6 @@ static void mei_me_remove(struct pci_dev *pdev)
free_irq(pdev->irq, dev);
pci_disable_msi(pdev);
- pci_set_drvdata(pdev, NULL);
if (hw->mem_addr)
pci_iounmap(pdev, hw->mem_addr);
--
1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/4] misc: pti: remove unnecessary pci_set_drvdata()
2013-09-23 1:35 [PATCH 1/4] misc: tifm: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-23 1:36 ` [PATCH 2/4] misc: ibmasm: " Jingoo Han
2013-09-23 1:37 ` [PATCH 3/4] misc: mei: " Jingoo Han
@ 2013-09-23 1:38 ` Jingoo Han
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-09-23 1:38 UTC (permalink / raw)
To: 'Greg Kroah-Hartman'
Cc: 'Arnd Bergmann', linux-kernel, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/misc/pti.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
index f84ff0c..eda38cb 100644
--- a/drivers/misc/pti.c
+++ b/drivers/misc/pti.c
@@ -892,7 +892,6 @@ static void pti_pci_remove(struct pci_dev *pdev)
}
iounmap(drv_data->pti_ioaddr);
- pci_set_drvdata(pdev, NULL);
kfree(drv_data);
pci_release_region(pdev, 1);
pci_disable_device(pdev);
--
1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-23 1:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-23 1:35 [PATCH 1/4] misc: tifm: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-23 1:36 ` [PATCH 2/4] misc: ibmasm: " Jingoo Han
2013-09-23 1:37 ` [PATCH 3/4] misc: mei: " Jingoo Han
2013-09-23 1:38 ` [PATCH 4/4] misc: pti: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome