* [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata()
@ 2013-05-23 10:44 Jingoo Han
2013-05-24 14:59 ` Guenter Roeck
2013-05-25 19:36 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-23 10:44 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Wim Van Sebroeck',
linux-watchdog, 'Guenter Roeck',
Jingoo Han
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/riowd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/riowd.c b/drivers/watchdog/riowd.c
index 0040451..4f99f12 100644
--- a/drivers/watchdog/riowd.c
+++ b/drivers/watchdog/riowd.c
@@ -206,7 +206,7 @@ static int riowd_probe(struct platform_device *op)
pr_info("Hardware watchdog [%i minutes], regs at %p\n",
riowd_timeout, p->regs);
- dev_set_drvdata(&op->dev, p);
+ platform_set_drvdata(op, p);
return 0;
out_iounmap:
@@ -222,7 +222,7 @@ out:
static int riowd_remove(struct platform_device *op)
{
- struct riowd *p = dev_get_drvdata(&op->dev);
+ struct riowd *p = platform_get_drvdata(op);
misc_deregister(&riowd_miscdev);
of_iounmap(&op->resource[0], p->regs, 2);
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata()
2013-05-23 10:44 [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata() Jingoo Han
@ 2013-05-24 14:59 ` Guenter Roeck
2013-05-25 19:36 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-05-24 14:59 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Wim Van Sebroeck',
linux-watchdog
On Thu, May 23, 2013 at 07:44:38PM +0900, Jingoo Han wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/riowd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/riowd.c b/drivers/watchdog/riowd.c
> index 0040451..4f99f12 100644
> --- a/drivers/watchdog/riowd.c
> +++ b/drivers/watchdog/riowd.c
> @@ -206,7 +206,7 @@ static int riowd_probe(struct platform_device *op)
> pr_info("Hardware watchdog [%i minutes], regs at %p\n",
> riowd_timeout, p->regs);
>
> - dev_set_drvdata(&op->dev, p);
> + platform_set_drvdata(op, p);
> return 0;
>
> out_iounmap:
> @@ -222,7 +222,7 @@ out:
>
> static int riowd_remove(struct platform_device *op)
> {
> - struct riowd *p = dev_get_drvdata(&op->dev);
> + struct riowd *p = platform_get_drvdata(op);
>
> misc_deregister(&riowd_miscdev);
> of_iounmap(&op->resource[0], p->regs, 2);
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata()
2013-05-23 10:44 [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata() Jingoo Han
2013-05-24 14:59 ` Guenter Roeck
@ 2013-05-25 19:36 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2013-05-25 19:36 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton',
linux-kernel, linux-watchdog, 'Guenter Roeck'
Hi Jingoo,
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/watchdog/riowd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Patch added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-25 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-23 10:44 [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata() Jingoo Han
2013-05-24 14:59 ` Guenter Roeck
2013-05-25 19:36 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome