RE: [PATCH] LP3971 PMIC regulator driver (updated and combined version)

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hello,

On Tuesday, May 19, 2009 12:47 PM Liam Girdwood wrote:

> On Tue, 2009-05-19 at 10:58 +0100, Mark Brown wrote:
> > On Tue, May 19, 2009 at 07:33:55AM +0200, Marek Szyprowski wrote:
> > > This patch adds regulator drivers for National Semiconductors
> LP3971 PMIC.
> > > This LP3971 PMIC controller has 3 DC/DC voltage converters and 5
> low
> > > drop-out
> > > (LDO) regulators. LP3971 PMIC controller uses I2C interface.
> >
> > > Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >
> > > +static int lp3971_dcdc_list_voltage(struct regulator_dev *dev,
> unsigned
> > > index)
> >
> > I'm OK with this but it looks like your MUA has mangled the patch by
> > word wrapping so Liam may not be able to apply it.  There's some
> hints
> > on configuring various mail clients in Documentation/email-
> clients.txt
> > which might be helpful.
> >
> 
> I've now applied the patch after it was mangled by outlook.

Thanks for your patience.

> I have also fixed the following build error :-
> `lp3971_i2c_remove' referenced in section `.data' of drivers/built-
> in.o: defined in discarded section `.devexit.text' of drivers/built-
> in.o
> [...]
> Best to pull for-next to get this fix.

Thanks for your fix!

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center