From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk,
kyungmin.park@samsung.com,
"'Mark Brown'" <mark.brown@wolfsonmicro.com>
Subject: RE: [PATCH] LP3971 PMIC regulator driver update
Date: Mon, 18 May 2009 12:43:52 +0100 [thread overview]
Message-ID: <1242647032.5473.2162.camel@vega.slimlogic.co.uk> (raw)
In-Reply-To: <000601c9d7ac$58af73d0$0a0e5b70$%szyprowski@samsung.com>
On Mon, 2009-05-18 at 13:32 +0200, Marek Szyprowski wrote:
> Hello,
>
> On Monday, May 18, 2009 12:15 PM Liam Girdwood wrote:
>
> > On Fri, 2009-05-15 at 10:20 +0100, Mark Brown wrote:
> > > On Fri, May 15, 2009 at 11:16:19AM +0200, Marek Szyprowski wrote:
> > > > This patch fixes issues reported by Mark Brown in his review of
> > National Semiconductors LP3971
> > > > PMIC regulator driver. It contains:
> > > > - a little code cleanup
> > > > - list_voltage() callback added
> > >
> > > > Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > >
> > > Looks good.
> > >
> > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> >
> > Doesn't apply :-
> >
> > Applying: LP3971 PMIC regulator driver update
> > error: patch failed: drivers/regulator/lp3971.c:91
> > error: drivers/regulator/lp3971.c: patch does not apply
> > Patch failed at 0001 LP3971 PMIC regulator driver update
> >
> > Could you regenerate against the voltage for-next branch.
>
> I've checked the
> git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6.git, the
> for-next branch. I looks that all tabs are converted to spaces in my
> previous patch. I've checked again it imho I've posted it properly. Maybe it
> was broken by merge conflicts in Makefile/Kconfig. What should I do in such
> case? Would you revert the broken version or do I need to post a patch for
> it?
>
I think it broke during merge (my fault). :-/ I'll revert it for now.
Could you resend and combine the original and update patches into the
one patch.
Thanks
Liam
next prev parent reply other threads:[~2009-05-18 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 9:16 Marek Szyprowski
2009-05-15 9:20 ` Mark Brown
2009-05-18 10:15 ` Liam Girdwood
2009-05-18 11:32 ` Marek Szyprowski
2009-05-18 11:43 ` Liam Girdwood [this message]
2009-05-19 5:33 ` [PATCH] LP3971 PMIC regulator driver (updated and combined version) Marek Szyprowski
2009-05-19 9:58 ` Mark Brown
2009-05-19 10:47 ` Liam Girdwood
2009-05-19 11:25 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242647032.5473.2162.camel@vega.slimlogic.co.uk \
--to=lrg@slimlogic.co.uk \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.brown@wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®