[PATCH 3/3] backlight: lp855x: remove goto err_dev

[PATCH 3/3] backlight: lp855x: remove goto err_dev

[Jingoo Han]

This patch removes goto err_dev, which makes code a bit smaller.

Cc: Milo(Woogyom) Kim <milo.kim@ti.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/video/backlight/lp855x_bl.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index aa6d4f7..c629fa8 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -272,14 +272,14 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id)
 	if (ret) {
 		dev_err(lp->dev, "i2c communication err: %d", ret);
 		if (mode == REGISTER_BASED)
-			goto err_dev;
+			return ret;
 	}
 
 	ret = lp855x_backlight_register(lp);
 	if (ret) {
 		dev_err(lp->dev,
 			"failed to register backlight. err: %d\n", ret);
-		goto err_dev;
+		return ret;
 	}
 
 	ret = sysfs_create_group(&lp->dev->kobj, &lp855x_attr_group);
@@ -293,7 +293,6 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id)
 
 err_sysfs:
 	lp855x_backlight_unregister(lp);
-err_dev:
 	return ret;
 }
 
-- 
1.7.1

RE: [PATCH 3/3] backlight: lp855x: remove goto err_dev

[Kim, Milo]

> This patch removes goto err_dev, which makes code a bit smaller.

Thanks !
IMO, goto statements are meaningful on _probe().
However, 'goto err_sysfs' also can be removed if the size of code is critical.

drivers/video/backlight/lp855x_bl.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
index 72a0e0c..7e4198c 100644
--- a/drivers/video/backlight/lp855x_bl.c
+++ b/drivers/video/backlight/lp855x_bl.c
@@ -268,29 +268,25 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id)
 	if (ret) {
 		dev_err(lp->dev, "i2c communication err: %d", ret);
 		if (mode == REGISTER_BASED)
-			goto err_dev;
+			return ret;
 	}
 
 	ret = lp855x_backlight_register(lp);
 	if (ret) {
 		dev_err(lp->dev,
 			"failed to register backlight. err: %d\n", ret);
-		goto err_dev;
+		return ret;
 	}
 
 	ret = sysfs_create_group(&lp->dev->kobj, &lp855x_attr_group);
 	if (ret) {
 		dev_err(lp->dev, "failed to register sysfs. err: %d\n", ret);
-		goto err_sysfs;
+		lp855x_backlight_unregister(lp);
+		return ret;
 	}
 
 	backlight_update_status(lp->bl);
 	return 0;
-
-err_sysfs:
-	lp855x_backlight_unregister(lp);
-err_dev:
-	return ret;
 }
 
 static int __devexit lp855x_remove(struct i2c_client *cl)
-- 
1.7.2.5

Best Regards,
Milo

Re: [PATCH 3/3] backlight: lp855x: remove goto err_dev

[Jingoo Han]

On Tuesday, August 07, 2012 5:32 PM Kim, Milo wrote:
> 
> > This patch removes goto err_dev, which makes code a bit smaller.
> 
> Thanks !
> IMO, goto statements are meaningful on _probe().
> However, 'goto err_sysfs' also can be removed if the size of code is critical.

OK, I will send v2 patch.

Best regards,
Jingoo Han

> 
> drivers/video/backlight/lp855x_bl.c |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index 72a0e0c..7e4198c 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -268,29 +268,25 @@ static int lp855x_probe(struct i2c_client *cl, const struct i2c_device_id *id)
>  	if (ret) {
>  		dev_err(lp->dev, "i2c communication err: %d", ret);
>  		if (mode == REGISTER_BASED)
> -			goto err_dev;
> +			return ret;
>  	}
> 
>  	ret = lp855x_backlight_register(lp);
>  	if (ret) {
>  		dev_err(lp->dev,
>  			"failed to register backlight. err: %d\n", ret);
> -		goto err_dev;
> +		return ret;
>  	}
> 
>  	ret = sysfs_create_group(&lp->dev->kobj, &lp855x_attr_group);
>  	if (ret) {
>  		dev_err(lp->dev, "failed to register sysfs. err: %d\n", ret);
> -		goto err_sysfs;
> +		lp855x_backlight_unregister(lp);
> +		return ret;
>  	}
> 
>  	backlight_update_status(lp->bl);
>  	return 0;
> -
> -err_sysfs:
> -	lp855x_backlight_unregister(lp);
> -err_dev:
> -	return ret;
>  }
> 
>  static int __devexit lp855x_remove(struct i2c_client *cl)
> --
> 1.7.2.5
> 
> Best Regards,
> Milo