From: Zhao Lei <zhaolei@cn.fujitsu.com>
To: "'Christoph Hellwig'" <hch@lst.de>
Cc: "'Tejun Heo'" <tj@kernel.org>, "'Jan Kara'" <jack@suse.cz>,
"'Jens Axboe'" <axboe@fb.com>,
"'LKML'" <linux-kernel@vger.kernel.org>
Subject: Regression caused by using node_to_bdi()
Date: Fri, 6 Mar 2015 12:37:21 +0800 [thread overview]
Message-ID: <004001d057c7$3cc1b2e0$b64518a0$@cn.fujitsu.com> (raw)
Hi, Christoph Hellwig
resend: + cc lkml
I found regression in v4.0-rc1 caused by this patch:
Author: Christoph Hellwig <hch@lst.de>
Date: Wed Jan 14 10:42:36 2015 +0100
fs: export inode_to_bdi and use it in favor of mapping->backing_dev_info
Test process is following:
2015-02-25 15:50:22: Start
2015-02-25 15:50:22: Linux version:Linux btrfs 4.0.0-rc1_HEAD_c517d838eb7d07bbe9507871fab3931deccff539_ #1 SMP Wed Feb 25 10:59:10 CST 2015 x86_64 x86_64 x86_64 GNU/Linux
2015-02-25 15:50:25: mkfs.btrfs -f /dev/sdb1
2015-02-25 15:50:27: mount /dev/sdb1 /data/ltf/tester
2015-02-25 15:50:28: sysbench --test=fileio --num-threads=1 --file-num=1 --file-block-size=32768 --file-total-size=4G --file-test-mode=seqwr --file-io-mode=sync --file-extra-flags= --file-fsync-freq=0 --file-fsync-end=off --max-requests=131072
2015-02-25 15:51:40: done sysbench
Result is following:
v3.19-rc1: testcnt=40 average=135.677 range=[132.460,139.130] stdev=1.610 cv=1.19%
v4.0-rc1: testcnt=40 average=130.970 range=[127.980,132.050] stdev=1.012 cv=0.77%
Then I bisect above case between v3.19-rc1 and v4.0-rc1, and found this patch caused the regresstion.
Maybe it is because kernel need more time to call node_to_bdi(), compared with "using inode->i_mapping->backing_dev_info directly" in old code.
Is there some way to speed up it(inline, or some access some variant in struct directly, ...)?
Thanks
Zhaolei
next reply other threads:[~2015-03-06 4:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 4:37 Zhao Lei [this message]
[not found] <003f01d057c6$eb48c3e0$c1da4ba0$@cn.fujitsu.com>
[not found] ` <20150308102916.GD3743@quack.suse.cz>
[not found] ` <20150308153423.GA24154@lst.de>
2015-04-01 9:56 ` Zhao Lei
2015-04-10 11:25 Zhao Lei
2015-04-12 11:33 ` Boaz Harrosh
2015-04-12 14:39 ` Boaz Harrosh
2015-04-13 1:20 ` Zhao Lei
2015-04-13 7:00 ` Zhao Lei
2015-04-13 10:22 ` Zhao Lei
2015-04-13 12:31 ` Boaz Harrosh
2015-04-14 12:14 ` Zhao Lei
2015-04-13 12:21 ` Jan Kara
2015-04-13 12:44 ` Boaz Harrosh
2015-04-13 17:32 ` 'Christoph Hellwig'
2015-04-14 12:27 ` Zhao Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004001d057c7$3cc1b2e0$b64518a0$@cn.fujitsu.com' \
--to=zhaolei@cn.fujitsu.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome