[PATCH 3.8-stable] gpio: fix wrong checking condition for gpio range

[PATCH 3.8-stable] gpio: fix wrong checking condition for gpio range

[Jonghwan Choi]

From: Haojian Zhuang <haojian.zhuang@linaro.org>

This patch looks like it should be in the 3.8-stable tree, should we apply
it?

------------------

From: "Haojian Zhuang <haojian.zhuang@linaro.org>"

commit ad4e1a7caf937ad395ced585ca85a7d14395dc80 upstream

If index++ calculates from 0, the checking condition of "while
(index++)" fails & it doesn't check any more. It doesn't follow
the loop that used at here.

Replace it by endless loop at here. Then it keeps parsing
"gpio-ranges" property until it ends.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 drivers/gpio/gpiolib-of.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index d542a14..ea537fa 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -228,7 +228,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)
 	if (!np)
 		return;
 
-	do {
+	for (;; index++) {
 		ret = of_parse_phandle_with_args(np, "gpio-ranges",
 				"#gpio-range-cells", index, &pinspec);
 		if (ret)
@@ -257,8 +257,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)
 
 		if (ret)
 			break;
-
-	} while (index++);
+	}
 }
 
 #else
-- 
1.7.10.4

Re: [PATCH 3.8-stable] gpio: fix wrong checking condition for gpio range

[Haojian Zhuang]

On 13 April 2013 22:46, Jonghwan Choi <jhbird.choi@gmail.com> wrote:
> From: Haojian Zhuang <haojian.zhuang@linaro.org>
>
> This patch looks like it should be in the 3.8-stable tree, should we apply
> it?
>

It could be merged into 3.8-stable tree.

Regards
Haojian

RE: [PATCH 3.8-stable] gpio: fix wrong checking condition for gpio range

[Jonghwan Choi]

Dear Haojian Ahuang.

> > This patch looks like it should be in the 3.8-stable tree, should we
> apply
> > it?
> >
> 
> It could be merged into 3.8-stable tree.
>

Thanks~

Best Regards.

> -----Original Message-----
> From: Haojian Zhuang [mailto:haojian.zhuang@linaro.org]
> Sent: Sunday, April 14, 2013 12:27 AM
> To: Jonghwan Choi
> Cc: Linus Walleij; stable@vger.kernel.org; linux-kernel@vger.kernel.org;
> Jonghwan Choi
> Subject: Re: [PATCH 3.8-stable] gpio: fix wrong checking condition for
> gpio range
> 
> On 13 April 2013 22:46, Jonghwan Choi <jhbird.choi@gmail.com> wrote:
> > From: Haojian Zhuang <haojian.zhuang@linaro.org>
> >
> > This patch looks like it should be in the 3.8-stable tree, should we
> apply
> > it?
> >
> 
> It could be merged into 3.8-stable tree.
> 
> Regards
> Haojian