* [PATCH] gpio: mc33880: use dev_err() instead of printk()
@ 2013-03-15 9:16 Jingoo Han
2013-03-27 8:53 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-03-15 9:16 UTC (permalink / raw)
To: 'Grant Likely'
Cc: 'Linus Walleij', linux-kernel, 'Jingoo Han'
dev_err() is more preferred than printk().
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-mc33880.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c
index b161489..3395879 100644
--- a/drivers/gpio/gpio-mc33880.c
+++ b/drivers/gpio/gpio-mc33880.c
@@ -130,7 +130,8 @@ static int mc33880_probe(struct spi_device *spi)
ret = mc33880_write_config(mc);
if (ret) {
- printk(KERN_ERR "Failed writing to " DRIVER_NAME ": %d\n", ret);
+ dev_err(&spi->dev, "Failed writing to " DRIVER_NAME ": %d\n",
+ ret);
goto exit_destroy;
}
--
1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: mc33880: use dev_err() instead of printk()
2013-03-15 9:16 [PATCH] gpio: mc33880: use dev_err() instead of printk() Jingoo Han
@ 2013-03-27 8:53 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-03-27 8:53 UTC (permalink / raw)
To: Jingoo Han; +Cc: Grant Likely, linux-kernel
On Fri, Mar 15, 2013 at 10:16 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> dev_err() is more preferred than printk().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-27 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-15 9:16 [PATCH] gpio: mc33880: use dev_err() instead of printk() Jingoo Han
2013-03-27 8:53 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®