From: Jon Hunter <jonathanh@nvidia.com>
To: Paul Kocialkowski <contact@paulk.fr>, <linux-kernel@vger.kernel.org>
Cc: <devicetree@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-tegra@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] ARM: tegra: nyan: Use external control for bq24735 charger
Date: Tue, 20 Sep 2016 18:40:06 +0100 [thread overview]
Message-ID: <00697eef-0b36-1ff5-9c7a-43c1b53b52bc@nvidia.com> (raw)
In-Reply-To: <20160828173246.32621-2-contact@paulk.fr>
On 28/08/16 18:32, Paul Kocialkowski wrote:
> Nyan boards come with an embedded controller that controls when to
> enable and disable the charge. Thus, it should not be left up to the
> kernel to handle that.
>
> Using the ti,external-control property allows specifying this use-case.
So the bq24735 is populated under the EC's 'i2c-tunnel' property which
is there to specifically interface it's child devices to the host. So I
am a bit confused why this is expose to the host if it should not be used?
Again you may right and I did find the original series [0] for this
which specifically references the Acer Chromebook that needs this.
However, I am not sure why this was never populated? Is there any other
history here?
What is the actual problem you see without making this change? The
original series states ...
"On Acer Chromebook 13 (CB5-311) this module fails to load if the
charger is not inserted, and will error when it is removed."
Cheers
Jon
[0] http://marc.info/?l=linux-pm&m=145447948705686&w=2
--
nvpublic
next prev parent reply other threads:[~2016-09-20 17:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 17:32 [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski
2016-08-28 17:32 ` [PATCH 2/4] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski
2016-09-20 17:40 ` Jon Hunter [this message]
2016-09-20 18:02 ` Paul Kocialkowski
2016-09-21 7:30 ` Jon Hunter
2016-09-21 7:56 ` Paul Kocialkowski
2016-09-21 10:10 ` Jon Hunter
2016-09-21 11:03 ` Paul Kocialkowski
2016-08-28 17:32 ` [PATCH 3/4] ARM: tegra: nyan-big: Include compatible revisions for proper detection Paul Kocialkowski
2016-09-20 17:41 ` Jon Hunter
2016-09-20 17:53 ` Paul Kocialkowski
2016-09-20 17:56 ` Jon Hunter
2016-09-20 18:02 ` Paul Kocialkowski
2016-09-21 7:34 ` Jon Hunter
2016-09-21 7:43 ` Paul Kocialkowski
2016-09-21 9:15 ` Jon Hunter
2016-09-21 9:31 ` Paul Kocialkowski
2016-08-28 17:32 ` [PATCH 4/4] ARM: tegra: nyan-blaze: " Paul Kocialkowski
2016-09-20 17:42 ` Jon Hunter
2016-09-20 17:15 ` [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter
2016-09-20 18:14 ` Paul Kocialkowski
2016-09-21 7:52 ` Jon Hunter
2016-09-21 8:26 ` Paul Kocialkowski
2016-09-21 9:06 ` Jon Hunter
2016-09-21 9:31 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00697eef-0b36-1ff5-9c7a-43c1b53b52bc@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome