From: Jon Hunter <jonathanh@nvidia.com>
To: Paul Kocialkowski <contact@paulk.fr>, <linux-kernel@vger.kernel.org>
Cc: <devicetree@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-tegra@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions
Date: Wed, 21 Sep 2016 08:52:20 +0100 [thread overview]
Message-ID: <0ca614bf-4d27-9948-03e3-472d059f2153@nvidia.com> (raw)
In-Reply-To: <1474395289.1215.20.camel@paulk.fr>
On 20/09/16 19:14, Paul Kocialkowski wrote:
> * PGP Signed by an unknown key
>
> Le mardi 20 septembre 2016 à 18:15 +0100, Jon Hunter a écrit :
>> On 28/08/16 18:32, Paul Kocialkowski wrote:
>>>
>>> This switches a few interrupt definitions that were using
>>> GPIO_ACTIVE_HIGH as IRQ type, which is invalid.
>>
>> May be you are right, but this does not describe why this is invalid.
>> Can you elaborate?
>
> GPIO_ACTIVE_HIGH is simply not the right kind of define to use in the
> "interrupts" devicetree property. Values provided there are understood as
> IRQ_TYPE_ defines.
Right, but you are changing the type as GPIO_ACTIVE_HIGH = 0 and
IRQ_TYPE_EDGE_FALLING = 2 and there is no comment about why this has
been changed. It might be correct, but you need to explain it.
Jon
--
nvpublic
next prev parent reply other threads:[~2016-09-21 7:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 17:32 Paul Kocialkowski
2016-08-28 17:32 ` [PATCH 2/4] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski
2016-09-20 17:40 ` Jon Hunter
2016-09-20 18:02 ` Paul Kocialkowski
2016-09-21 7:30 ` Jon Hunter
2016-09-21 7:56 ` Paul Kocialkowski
2016-09-21 10:10 ` Jon Hunter
2016-09-21 11:03 ` Paul Kocialkowski
2016-08-28 17:32 ` [PATCH 3/4] ARM: tegra: nyan-big: Include compatible revisions for proper detection Paul Kocialkowski
2016-09-20 17:41 ` Jon Hunter
2016-09-20 17:53 ` Paul Kocialkowski
2016-09-20 17:56 ` Jon Hunter
2016-09-20 18:02 ` Paul Kocialkowski
2016-09-21 7:34 ` Jon Hunter
2016-09-21 7:43 ` Paul Kocialkowski
2016-09-21 9:15 ` Jon Hunter
2016-09-21 9:31 ` Paul Kocialkowski
2016-08-28 17:32 ` [PATCH 4/4] ARM: tegra: nyan-blaze: " Paul Kocialkowski
2016-09-20 17:42 ` Jon Hunter
2016-09-20 17:15 ` [PATCH 1/4] ARM: tegra: nyan: Use proper IRQ type definitions Jon Hunter
2016-09-20 18:14 ` Paul Kocialkowski
2016-09-21 7:52 ` Jon Hunter [this message]
2016-09-21 8:26 ` Paul Kocialkowski
2016-09-21 9:06 ` Jon Hunter
2016-09-21 9:31 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca614bf-4d27-9948-03e3-472d059f2153@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome