[PATCH 3.9-stable] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel

[PATCH 3.9-stable] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel

[Jonghwan Choi]

This patch looks like it should be in the 3.9-stable tree, should we apply
it?

------------------

From: "Axel Lin <axel.lin@ingics.com>"

commit 78040b630f28298e0ecb56bf1bc53c7976314eab upstream

It is necessary to clear MC13892_SWITCHERS0_SWxHI bit when set voltage to
the
voltage range from 1100000 to 1375000. Leaving MC13892_SWITCHERS0_SWxHI bit
untouched may result in wrong voltage setting.

For example, currently switch voltage from 1400000 to 1300000 will set the
voltage to 1800000 because the HI bit is still set.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@sirena.org.uk>
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 drivers/regulator/mc13892-regulator.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/mc13892-regulator.c
b/drivers/regulator/mc13892-regulator.c
index 9891aec..cc76c52 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -465,13 +465,13 @@ static int mc13892_sw_regulator_set_voltage_sel(struct
regulator_dev *rdev,
 	 */
 
 	if (mc13892_regulators[id].vsel_reg != MC13892_SWITCHERS0) {
+		mask |= MC13892_SWITCHERS0_SWxHI;
+
 		if (volt > 1375000) {
 			reg_value -= MC13892_SWxHI_SEL_OFFSET;
 			reg_value |= MC13892_SWITCHERS0_SWxHI;
-			mask |= MC13892_SWITCHERS0_SWxHI;
-		} else if (volt < 1100000) {
+		} else {
 			reg_value &= ~MC13892_SWITCHERS0_SWxHI;
-			mask |= MC13892_SWITCHERS0_SWxHI;
 		}
 	}
 
-- 
1.7.9.

Re: [PATCH 3.9-stable] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

On Wed, May 22, 2013 at 01:55:32PM +0900, Jonghwan Choi wrote:
> This patch looks like it should be in the 3.9-stable tree, should we apply
> it?

It doesn't seem particularly urgent (it wasn't new code) and we've not
seen any feedback from anyone who actually uses the device.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]