mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH net v2] page_pool: Add myself as page pool reviewer in MAINTAINERS
Date: Wed, 8 Nov 2023 11:31:45 +0800	[thread overview]
Message-ID: <0098508e-59ab-5633-3725-86f1febc1480@huawei.com> (raw)
In-Reply-To: <20231107094959.556ffe53@kernel.org>

On 2023/11/8 1:49, Jakub Kicinski wrote:
> On Tue, 7 Nov 2023 20:38:24 +0800 Yunsheng Lin wrote:
>> I have added frag support for page pool, made some improvement
>> for it recently, and reviewed some related patches too.
>>
>> So add myself as reviewer so that future patch will be cc'ed
>> to my email.
> 
> Not sure what to do about this, it feels somewhat wrong to add
> as a reviewer someone who seem to not follow our basic process
> requirements:
> 
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html

I reread the above doc in order not to miss anything obvious again:(

I suppose basic process requirements mean:
1. designate your patch to a tree - [PATCH net] or [PATCH net-next]
2. don't repost your patches within one 24h period

For 1, somehow I got the impression that changing to MAINTAINERS
can be targetted to net branch, so that the change can flow to other
main trees quickly, maybe I was wrong?

For 2, yes, maybe I should stick to the rule even if it is a simple
patch and obivous format error.

Please correct me if there is anything else I missed.


> 
> :(
> 
> .
> 

  reply	other threads:[~2023-11-08  3:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 12:38 Yunsheng Lin
2023-11-07 17:49 ` Jakub Kicinski
2023-11-08  3:31   ` Yunsheng Lin [this message]
2023-11-08  6:49     ` Ilias Apalodimas
2023-11-08 16:47     ` Jakub Kicinski
2023-11-09  9:43       ` Yunsheng Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0098508e-59ab-5633-3725-86f1febc1480@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®